From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2059.outbound.protection.outlook.com [40.107.223.59]) by sourceware.org (Postfix) with ESMTPS id 14F20386D611 for ; Fri, 15 Dec 2023 12:08:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 14F20386D611 Authentication-Results: sourceware.org; dmarc=fail (p=quarantine dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=amd.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 14F20386D611 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.223.59 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1702642121; cv=pass; b=vsis0G5N9rNE4pAGLqBqyhCVslaVeUNPG08G3Y4ALEQvfES9uJghJ0bRD1Zbl+SGdrPfjkzyLZgYRgSeMqA7cDve6GJ56CArSBmVlhOg6lKyi0cNdROd1rvYRTWTWeuF7a5xQ2eUiuYjOBOgtmao54/jJvnBgqAOsWEdLDSoGpk= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1702642121; c=relaxed/simple; bh=LwjeZK58M54aJemOU5mblZjvPwtSyh3rLXiqffUMXvM=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=W0HjBw+vJpsqtVbHB+jpY2ZhmfT+FfMBSUo6folczQ+UB/l0L3508OdNT/Lb3/mvWOJ2mArhd0L+seBIjylP+Rd0TA/4B6L69tEij1vuYBq4Kseik544hn9wFxhxwrjumnYz5PzZ6y6w50aItkm4nr6gp6yyDDqe/merLRJqlVo= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eajW3Ib8enB+xE64LwXTX3U5At1Gv1NWtbbr6ieWYILPBV7ZWg0V1KWGagw4VRsBA5qi3YgQzKXngUUy1DUzv87aZmq4hm2jh+gVSr13tqzzph2azQ5gry50ckzMJAuV5uXyr5a1SAYoMekZ86xLDia2Eks9mgnmbckaf+HNE0U++Zk8dThxke041ImbpV95LpUFi1vHca2xRlPV4y1Tn3anUQIJnOe7uKp9NnvaKi+w0/LaRUyzAs9IZPqO/Cy3HZtnm0AJwiMG/xl/Lftnd/FJRDjJ8jKFo5Qnd1EYTK8i1kPFvQCOMgWzzZ8gmuTKXQFozDni2cKdcNK67/wXdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4vlC/MckMGyRL6TVFlWUNXsf3kRSHZp8Uc6Vhtyiyyk=; b=YL0aJhBuVBojmiOUjC53Rrzppd3EYCK3XmMyUGcxHWXer1tzkFuKu5XmqGBSYzsm8SytAF3ajvTgzVREs0UFel64fgpEsw7ogi3xpeakacVGoNlutBemohxLPGblUPdxsenn3nmVeNSvndNXlEeVv6GyPgPJq/C87t3KuoFUzm14r/Em8ELG80SdWFnlizxscW/+SyeRYK3MhKRgMSr/u0uVeFo6yq8TlNrBGgwFZx6y8UCQdX6YbucUTuvCCRAnSa49Mk8IylOLAOtfrqB5aR5HWkzzem5QFnp8IUoc5YO7+2GBCQEhmrYEvBmIvNNjjxfoV9RxBn2QACh9ybvHZA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4vlC/MckMGyRL6TVFlWUNXsf3kRSHZp8Uc6Vhtyiyyk=; b=MTDZiJdxgtGgJqAXMFNWs06VHaVT5VTJ/TZZWa7iosEMLl9LQig6NrZJ39rpgZsYyIrkGLrx26v/Duap4DAroihTypVHRFTi29/NhP7qHTA5/npyUSlWFP8m/najSCJCskGkrFYlAujWAfbuDx0ij2/HvFkclv7scq0udES840M= Received: from CH2PR12MB5004.namprd12.prod.outlook.com (2603:10b6:610:62::16) by CY5PR12MB6036.namprd12.prod.outlook.com (2603:10b6:930:2c::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.31; Fri, 15 Dec 2023 12:08:37 +0000 Received: from CH2PR12MB5004.namprd12.prod.outlook.com ([fe80::cd8a:4814:157c:bbe]) by CH2PR12MB5004.namprd12.prod.outlook.com ([fe80::cd8a:4814:157c:bbe%7]) with mapi id 15.20.7091.030; Fri, 15 Dec 2023 12:08:37 +0000 From: "Frager, Neal" To: Thomas Petazzoni CC: "newlib@sourceware.org" , "cjwfirmware@vxmdesign.com" Subject: RE: [PATCH v1 1/1] configure: correct tooldir install path Thread-Topic: [PATCH v1 1/1] configure: correct tooldir install path Thread-Index: AQHaLzzaR7gfNj1QuUaymX4Pt5cHB7CqJdMAgAAZ1ZA= Date: Fri, 15 Dec 2023 12:08:37 +0000 Message-ID: References: <20231215095529.739093-1-neal.frager@amd.com> <20231215113332.4a0fd114@windsurf> In-Reply-To: <20231215113332.4a0fd114@windsurf> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH2PR12MB5004:EE_|CY5PR12MB6036:EE_ x-ms-office365-filtering-correlation-id: 39148055-55f4-44b3-fddc-08dbfd66919b x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: a3GL2S8O53Oc7FIJwaSKiplOSWm9CMHacsE3YYGxElH0pJJZSD9YbFzZC96TVmn2rRKi8s135MZSetJ0W6dFv2YVAnVtes6zv2eb0TtwQcuin++2SVldDPKcHbZ0Ni49yxzt+ATv7skthJ4s7OEBz0iBcVOlvZbOSd+ak+Fkwl82BoHQr2X06MUHpgf0EpkVvYnoEh/nWVrRpPUyO/coDdVoTaxnsLLk/3MWchSLiuN4zqT4p25My8eAkwlUhdNO48zHW0YxOW0Xcn2EOM6J5SITLx3vZYl7buoeok99/sNdoa/5UGyAeEG6I0fNXiT8JEon8YUmo765v+FlIA56xOyrMPYwaKwxtG09wHysHK+PRmT4Ak0A/CTt2zEFT9aVPxGQpIKttowMtye2iqctwrGzxHOhgY8XQ+Z3hgXGS0FR00tlaWCikFEJOCtoIG3IPpc1XBGmblUAneQQkJj1IAaVAFsu2vrHrabW6DQGXFIBM1RPrWgVsz33rW1e63RspPp3n4SqmHuTf0nU3yVDUhOFucyVnQh7TpjU6jefIToU34wLy+s/gLsuC2EVpOcLvzTefn+xQlyh2BCIX9l9WPsLhTrW3VUcp4XFfQNXpRwrN41J8s0Y6mcUbrV0vJRu x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH2PR12MB5004.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(39860400002)(376002)(396003)(366004)(136003)(346002)(230922051799003)(186009)(64100799003)(451199024)(1800799012)(55016003)(26005)(7696005)(6506007)(33656002)(38070700009)(86362001)(38100700002)(122000001)(4326008)(52536014)(5660300002)(9686003)(71200400001)(76116006)(6916009)(316002)(66946007)(8676002)(8936002)(54906003)(66556008)(66476007)(66446008)(64756008)(2906002)(41300700001)(478600001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?L/avU54eEuMg0s8EzkJN4R1OTmobWqeF4Xu6BGGl2wE0Pmq1HUqUycsfklvl?= =?us-ascii?Q?PIfU974R2MkDNch0VtIYOboqcpVsPGv2RtF6rhX626hu3tCyN9MIybPi8xGz?= =?us-ascii?Q?DWabGqM7m1bIlZiiMjqy5DTnMdQfBumpt0dipgzxZHKmpinG/PSuZ1fsKOvJ?= =?us-ascii?Q?abpfDaPc8R3QaNnV/WpROyQg9M5ppl/xD0gUMDZ/GB7kCgAI/TBL6ml9EWZL?= =?us-ascii?Q?0N9R/S/j7fjynNAWWW5Ved/iQ+rmNB/qRbgXpR+p1ol6O1A2NM8NFfORMmYr?= =?us-ascii?Q?1sDTmhVkkV7xAhLmx0vE6qUd6EQmCvr/k6hd5CQQBgjLJHxikZCOraXqefAY?= =?us-ascii?Q?Rn6Dlky6NeJLNMeew/iuVMJRkcqK5b3KOu8ajE921hXVjpbAGnYKsqDt7FeQ?= =?us-ascii?Q?T0v96fJXnoXJKt/dSP9O4Ybme0nitgEMpYitfz9+FkhXZ4CVnQCKL3swd/eH?= =?us-ascii?Q?ks0aHfvq4RXoZVXOm8nA9lR73JdFoB4zIO0ZVAsmxSMBbKTiPXgoN1XKUmKP?= =?us-ascii?Q?DulrKNu0ojkYsWQf++wdmNLJfwJDqf5XNAv9ILODhAHKfqWLxf/UyQHxs57F?= =?us-ascii?Q?abAXTrbhnARWWmejd5zHmyGv8FzlYvtpS7BoWfXggrbnpt8/DcQypq2zG2hL?= =?us-ascii?Q?FKqUdvzr08iZHmHQUGWLHdMYbR334lE8H34kk6HyT5E9XAVxEgId5ABRgjec?= =?us-ascii?Q?Kj2gITegEyGhOnxQYseLNITQUqi6iISZV/xplqjBCs2bzeUeanz9YSB7/j0s?= =?us-ascii?Q?OFQ40uavvP3EC3WFJ1dvXodgeOWMGDjnciMV7xPmNEQ1sAQ6YQgw0xTkyzro?= =?us-ascii?Q?B10hL6O0UGHndvsi/4lykOhL2E1TSU6NDNuv8yNqnOl69aKxEwqb1oHC8UY+?= =?us-ascii?Q?omRj5Ol7yKiNSLeIR+/6DIUudLyLDHxk04Yf4TLOKUbRrnQfUZxxGD45kZ2j?= =?us-ascii?Q?RdG+Iu4y214plA1EByZVCGBr4Me5Nr5Al517+rdNDRMVN3M/JRlsNsYUENf3?= =?us-ascii?Q?IOOIZBSHx4R6VYA3biuLF8OISs5P0VchHVkB+WQmofz/gX9Vn4ekYN0sJodr?= =?us-ascii?Q?tw6QF6jOx+pIfRe5MH4Va3bGgGEzoqcGiPqU+nGXUYPMgtQwlEpVw1W37m36?= =?us-ascii?Q?IOJx2zPIEH0dU9+cESK0D1evE0andtFzDGFenyHUjuozQJvOZsBeunvFsfZR?= =?us-ascii?Q?ptuwnqztodPmZIzQH92hwRJV0FmBlRz77aVGp57qCuB+AFs2zIVzh+dgqA1l?= =?us-ascii?Q?B9FRdsH2dhQnChDWGluG+ySgxAyxZxztJXgg8evTdE4V/uTuxojF4CJHw8KP?= =?us-ascii?Q?33rV51WlRFFso32ZSVwBaIFhx9SdsVylNl+zu3WCIYXZ8c0NNIWWgAwPpSf2?= =?us-ascii?Q?Ed0WNDcYqTT2LGkWi+YwQKuQAMbTWp2gt4cBEevaQwgRH3jNsfXK/VCz3Pi6?= =?us-ascii?Q?GaPKIHVgs/LQgWiYYWyITejx5zTMuby1CPOAKDMkXDgYxHUORk6Qzz05aVSN?= =?us-ascii?Q?ZuoRrbkCE/qmnSTMySy70ppxH3LpUhVdA76OH/wRR8xrkFcNkF4+G6cWOSh2?= =?us-ascii?Q?nf/XU8egbAgzHynb14A=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB5004.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 39148055-55f4-44b3-fddc-08dbfd66919b X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Dec 2023 12:08:37.3879 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xVpr3f36ltpm+k5Z7b5DVURMm3sIy90DWqWxUI4sAeK8bAkXi1JRLIj6CSz97hJs X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6036 X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Thomas, > This patch is required to fix how the newlib headers are installed > when using a sysroot install directory. >=20 > The cross compiler expects headers to be in > .../host/usr/arm-none-eabi/sysroot/usr/include/newlib.h > by default newlib installed the headers into > .../host/usr/arm-none-eabi/sysroot/usr/arm-none-eabi/include/newlib.h >=20 > ${exec_prefix} provides the .../host/usr/arm-none-eabi/sysroot path > ${target_noncanonical} provides an extra arm-none-eabi/ that must be remo= ved. >=20 > Signed-off-by: Neal Frager > Co-developed-by: Chris Wardman > --- > configure | 7 +++++++ > 1 file changed, 7 insertions(+) > The configure script is generated from configure.ac, so you should not > patch configure but configure.ac. When building newlib, I am not seeing the configure script get generated. If I only patch configure.ac, the configure script stays the same and my patch appears ignored. Do you know what I could be missing? > + --with-install-sysroot use sysroot install directory > --with-debug-prefix-map=3D'A=3DB C=3DD ...' > map A to B, C to D ... in debug information > --with-build-config=3D'NAME NAME2...' > @@ -7057,7 +7059,12 @@ esac > =20 > # Some systems (e.g., one of the i386-aix systems the gas testers are > # using) don't handle "\$" correctly, so don't use it here. > +# Check whether --with-install-sysroot was given. > +if test "${with_install_sysroot+set}" =3D set; then : > --with/--without options are usually not used for boolean things, > instead --enable/--disable option are used for boolean things. > However here, I think that what would make sense is a --with-tooldir > option. When not passed, the value is > '${exec_prefix}'/${target_noncanonical}, and when passed, the value is > the one passed in the option: > ./configure ... --with-tooldir=3D/blabla I made this correction, and the --with-tooldir option only works if I patch it directly into the configure script. Could you help me figure out what is missing? Best regards, Neal Frager AMD