From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2077.outbound.protection.outlook.com [40.107.93.77]) by sourceware.org (Postfix) with ESMTPS id 27ECC3858CDB for ; Tue, 9 Jan 2024 14:18:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 27ECC3858CDB Authentication-Results: sourceware.org; dmarc=fail (p=quarantine dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=amd.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 27ECC3858CDB Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.93.77 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1704809934; cv=pass; b=VIBrxlwqTP4zIZ4puS3LIW4N5p0MlM/Sj04E/BA6bgpgnZpSZX6HoBbJhzNBHotHQTV4Xxu/+ukF0rIOnDbVMVw3FLj6SIu9Eiy+mI4UMxc/aDgKVr7PYGEF1YtfxXFcsGVzwqarcBkYI2hOCUz/dviZ34nVp5JmBG9P26t4Ilc= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1704809934; c=relaxed/simple; bh=nGoeMtcBLckC5y45YXrBJAr+257T9/RsriqKELhcgSI=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=dsoW4Rn49hC6xLXnBirbcN1sy98OWwBN+KWjzf/uiAGrEngUPycz4DQrrGKyj9/rWTD4jW8+5dcAHfS5VqzWQTPZ+XDSZq0Yz72lKaWP3mFEjjTbO+3zPXdi3IEoijsdfDeHVJicVtYn5fAMHKvgWxHi7bC+w1g3MceU0qo7v1M= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BZakpILm8QS2zbej/XM28y4qpWlVpl0oTzQrzwmtElDmzju5JPOhh0u4IpcsIQH7pggkTLqmX1OJsY3cwUS5uMtrjm/L8YG6kEuQVYascXAnfrMddoRWZ09rtuUU5Y/jkkvTuVH4acB+zq/LRzWs9SxnwMDP46e3RMWeAGTe4/szJfcnBfkUfRYG4NiNIS6OiIMlr6v1014EYofUMqWLZkMFQ3q6Bi8l+KKHuX6hiTVkoQi9OpJKYJDh4UOAfIHN9w5dnV6Dmze8MptQm8Xf7/FWa2dkxMjDX8sZJsEl5u5X6pWkzVi5vOvS+O04CBbcrZgmsJ1MOKqkWVLqh7Y+hg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tw5MIzdBrHReiDWf7a12CH9WXlGdsnubWnaBUPvEGsc=; b=GKqw5urTzuCDME6mBoClsF7nz0THXSAgQkNXFdrh7/8OfLXsBzMNA1pxIOlC/9FeKGFxN3LU5QUvw329tPHcdVGa+qCdTh5cPusYjNRx7gk0rXzfIH/OWtOT2RrBijmBAXnEYDUMZGjdkrRJolUEeS7xXcnGpLTnUhOW9OsfhVD0Ir+eWGu7mYCRshHbF8wi+Op8mJwVS4YjRiPQRSkyYQFQBscxgPkaIlLXS/RxoaudFA+q3TbHVujc47o8tM6MkdCQpnFo2My0UOhQkAlxGmoas5LA1+QWgXr0lTdbejZTD1nAWj/kIUuMCISyVmd9ZE0HMM5ah4WDySVrS12nUw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tw5MIzdBrHReiDWf7a12CH9WXlGdsnubWnaBUPvEGsc=; b=emmAC1fq/D+FRvGPE/Fu+v1A80AAaP+1ZME01LRf1wDIYlHZQFSrxhqGRZzr+DlHq5qn2MVVSCoAcLjiZq5LqioqofHGGFgMC76xX2RcAo3Evf3629VfQllwUPe36sIH818MBIowFnuLopvXz6jK6tkOAkhvoNeSupoHnBZFrz8= Received: from CH2PR12MB5004.namprd12.prod.outlook.com (2603:10b6:610:62::16) by DM4PR12MB6009.namprd12.prod.outlook.com (2603:10b6:8:69::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.23; Tue, 9 Jan 2024 14:18:45 +0000 Received: from CH2PR12MB5004.namprd12.prod.outlook.com ([fe80::cd8a:4814:157c:bbe]) by CH2PR12MB5004.namprd12.prod.outlook.com ([fe80::cd8a:4814:157c:bbe%7]) with mapi id 15.20.7159.020; Tue, 9 Jan 2024 14:18:45 +0000 From: "Frager, Neal" To: "jjohnstn@redhat.com" , "thomas.petazzoni@bootlin.com" CC: "cjwfirmware@vxmdesign.com" , "newlib@sourceware.org" , "Frager, Neal" Subject: RE: [PATCH v2 1/1] configure.ac: configurable tooldir install path Thread-Topic: [PATCH v2 1/1] configure.ac: configurable tooldir install path Thread-Index: AQHaQuhE4cilux8NUUSmAtpmoMfdIbDRhROQ Date: Tue, 9 Jan 2024 14:18:45 +0000 Message-ID: References: <20240109103953.1112223-1-neal.frager@amd.com> In-Reply-To: <20240109103953.1112223-1-neal.frager@amd.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH2PR12MB5004:EE_|DM4PR12MB6009:EE_ x-ms-office365-filtering-correlation-id: dafc85c1-4185-4175-4fdc-08dc111de3ae x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 19SoWdnow4p2M0NVkK9eXEGTVGQR/kC8X1qCScAZtvdfMCt+mblyiFjJ9OQqiRpW4Hdh77bkCa1EpNbEF8PO5oFqyBy0pRsjIFn77deST3wNq31R991QJv5Qt9YqRzffKBgdQRDW3HA4SgdQFWJRlyeW5saQVr1WL55v4ZQzTRMaStf4X2xJhJNwGC+uy3u69ktNbmkd6bvAvAgOqNcVTTvZ37yAM8melqErYPAi6/cDlJ/dPPa3A0FzvKEjsG3SB1q/vTriVf5DOcD5HipWKiTv13SjGdLz4X9x3zk+X7iPXhZ+lO/zWG7PQo+oZcpoZiHiaQPi5Rhrfo+itZul8q7Tszbrdh5KOETBUSWrDM3adYK2UTbAy4ai6T804g3pgq4rCYYaTYUt5Oz/s8071AIlr1Xl5yJ/91bN/CDMnOxSKpf8p9NML//RWzvqWXlGWGWosfKCD3mnZkMhH4Rc3ppJT6R9gJYmxT3TJavkZvli8i3i+28Ra2HfjPlTSmzV9zSsghGds+YI1CvY4NYBI00lfJvtYvcDRlLfLtj1r7WSU4IFPI+K5SCWUABfuF7iDrZLzrYJs5ht+Nzjv1kAwG1qP/37Om3MkB1P/96GWDLqAqPC/YB+abxcYMHFZwbU x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH2PR12MB5004.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376002)(136003)(396003)(366004)(346002)(39860400002)(230922051799003)(186009)(64100799003)(1800799012)(451199024)(478600001)(8936002)(8676002)(4326008)(52536014)(76116006)(66946007)(66476007)(66446008)(66556008)(64756008)(54906003)(316002)(7696005)(26005)(83380400001)(9686003)(71200400001)(110136005)(6506007)(5660300002)(2906002)(41300700001)(33656002)(38070700009)(38100700002)(122000001)(66899024)(86362001)(55016003);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?NiYurKVasOn69st/MzhJ3F7voYbzV0wPQ0XLU/yyTL5Hqp0mEEEtIB9+R/5X?= =?us-ascii?Q?CmUu0Z9APrlmf6IsNRVY7oNF0ytn6EtASJgch4WiAOUt6yGnhgkuCa0HtRXZ?= =?us-ascii?Q?akBkN+tyZeyTJCRLS4oPMP5tBozhooEKg8nx0+QYbfIv7TVYSom9ahDWdm12?= =?us-ascii?Q?A9lX89KPbw62vBpLLVFfIsFLwkdMBqD1opCkktDe//+OWNsDWH6NnH5DjETB?= =?us-ascii?Q?X3uHgfOkodMJLFHFbi9gWTf+4MFt76LOTLmWDsJyz5OHSK/CKwSwoNbRAM8j?= =?us-ascii?Q?kUtQslCYa2xUSZcEYRZlMb8uk+qGMgnyAHNouSEWg4GHsJSM2XaGmSpN8vCZ?= =?us-ascii?Q?DqjTfTk4gSbutOX7nlVn5K/xwuGgYxl2wo8kqVo/n5Mx1RzMjqHk71xRbLNe?= =?us-ascii?Q?UfJbCWeBqwnQRYmE3NQNtvMMk9lRYKf1Tdo+aDvVVALxv2LnHCcaqAscliu1?= =?us-ascii?Q?B/zmRmuNOQbgO+yqI71Fdt3unyevgpn9328vcjWcL5QtD4w6+G8PLiS/dT5+?= =?us-ascii?Q?PxuY7ukoD3v89szIMpKDSrl0/5PIBYcy22KXIxG+wDNjeRDybWdgLwMiend+?= =?us-ascii?Q?RExqNHXt7VZGHngtCZeTWQrENCO6s8GsawFANRYTZz2Wnblef+8cgiU0iGpY?= =?us-ascii?Q?YNNcVsfaUwSY6CfMkstbbv5tVjcW06vCwcR+p7R0npNU0T47KYkWT6DPGx/z?= =?us-ascii?Q?BffypikB1tYrmNwlmca8h3OkoYWyxm9QsG9rCngvj8cvZbNgQv+vE7QrRctt?= =?us-ascii?Q?7stBU/pV9F6ayGcQR3jRknlP9oVyYSlPXRH+eTtwT/B3qfhP7yiJHWUoSyg9?= =?us-ascii?Q?d48Hk+WPhPE6HXUlZ7z8fOUQ6qWzn8Qbi6c8pzibM5imujjYVkQeT+Z9BqoA?= =?us-ascii?Q?3fhpbRwZ4/zzvT45bIyoJDAVS56m+fZarO56ZEwyUSNKWaozJAk3t/jmIC64?= =?us-ascii?Q?L2siMSEZRUGgY2wZRTapuTQ0v8ci4pFTzSlryC/GoA+Vgih7/PwNnuDkzyit?= =?us-ascii?Q?sD3gAV3KyjUeS42Ho9yoKmjkfe2DwX6+GYHH9qqrtN75U1Oi/eA8OLiRocGf?= =?us-ascii?Q?qg0l+j1YKWu4PLODaNJtBV2PnjnsrLSp3tt+JENbFsH9ZB7FxQMsbPX4Wi1J?= =?us-ascii?Q?uz+Ogj+zQfOZQF24yMJpgLPRHOCrBJE9JYLbVUnOVQtL5BTWwkHFTPk6Vk6V?= =?us-ascii?Q?ifdAdbqFUzvOXxeCQ23b4+Oigo8R1szBEw8d4xpNtgebTDBJKw91jFq7GWAQ?= =?us-ascii?Q?gl4FoGWzgexfuH+egHvIwZIVmOvs3aKrbPvVnGq3K2LFO8f9Sclf0kYPyZGA?= =?us-ascii?Q?jWGgajJ0Ub3CFVFQ4Dq8Fv4PobVp+1f7dqYRGs/XSCcAo8/6N9PtnPjkGvQx?= =?us-ascii?Q?qqW3NS1P7Bo5c4Vy7PSGZx6wEteL2nmk//ZbNKaw/fzwT3z6nIVf0bByK8Tt?= =?us-ascii?Q?ztDM8rstLZvWtcQP40Mz0QaqsTNVg1i1Uae+IRD/JS4W3kKtt2BC6d9JIR0J?= =?us-ascii?Q?jPszjcGuphS7cXsA0Gn0vvS7C66B4kNarJ3vDJExkU2aloAhDD2EVAg8fGmV?= =?us-ascii?Q?zuZc89wpT3euNwGb4KU=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB5004.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: dafc85c1-4185-4175-4fdc-08dc111de3ae X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jan 2024 14:18:45.1045 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: NJo2u6+jKx5EheaZdyDBH0S7t3CaA6Cf5l0Vqcc+YoKcTCppJAA4SHVcV5fhmrvH X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6009 X-Spam-Status: No, score=-11.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Jeff, Thomas, Thank you both for your assistance with the patch below. I am now dealing with a version conflict between newlib and buildroot. I hope you can help me find the best solution for it. On my machine, I have tested the patch below using autoconf 2.69. However, the goal is for this patch is to ultimately integrate with buildroot. Currently, buildroot hardcodes the autoconf version that it builds and uses to version 2.71. But with autoconf version 2.71, I get the following error from the newlib configure.ac because it requires specifically version 2.69: >>> newlib-bare-metal 4.3.0 Autoreconfiguring configure.ac:34: error: Please use exactly Autoconf 2.69 instead of 2.71. config/override.m4:12: _GCC_AUTOCONF_VERSION_CHECK is expanded from... configure.ac:34: the top level As you are newlib and buildroot maintainers, could you please help me with guidance about how to resolve this issue? =20 I can easily make a patch to make the autoconf version used by buildroot configurable, but I would like your opinions before I proceed. Thank you again for your support! Best regards, Neal Frager AMD > This patch is required to fix how the newlib headers are installed > when using a sysroot install directory. > The cross compiler expects headers to be in > .../host/usr/arm-none-eabi/sysroot/usr/include/newlib.h > by default newlib installed the headers into > .../host/usr/arm-none-eabi/sysroot/usr/arm-none-eabi/include/newlib.h > ${exec_prefix} provides the .../host/usr/arm-none-eabi/sysroot path > ${target_noncanonical} provides an extra arm-none-eabi/ that must be remo= ved. > With this patch, users can specify the tooldir path that is needed. > Signed-off-by: Neal Frager > Co-developed-by: Chris Wardman > --- > V1->V2: > - migrated patch to configure.ac > - changed option name to --with-tooldir=3DPATH > --- > configure.ac | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) > diff --git a/configure.ac b/configure.ac > index f1bb72100..9a01c1562 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -2599,7 +2599,18 @@ esac =20 > # Some systems (e.g., one of the i386-aix systems the gas testers are > # using) don't handle "\$" correctly, so don't use it here. > -tooldir=3D'${exec_prefix}'/${target_noncanonical} > +AC_ARG_WITH([tooldir],=20 > + [AS_HELP_STRING([--with-tooldir=3DPATH], > + [use given path to install target tools after build])], > + [case x"$withval" in > + x/*) ;; > + *) > + with_tooldir=3D > + AC_MSG_WARN([argument to --with-tooldir must be an absolute path]= ) > + ;; > + esac], > + [with_tooldir=3D'${exec_prefix}'/${target_noncanonical}]) > +tooldir=3D'${with_tooldir}' > build_tooldir=3D${tooldir} =20 > # Create a .gdbinit file which runs the one in srcdir > --=20 > 2.25.1