From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx08-00376f01.pphosted.com (mx08-00376f01.pphosted.com [91.207.212.86]) by sourceware.org (Postfix) with ESMTPS id CEC3F3858D35 for ; Tue, 26 Sep 2023 11:07:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CEC3F3858D35 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=imgtec.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=imgtec.com Received: from pps.filterd (m0168888.ppops.net [127.0.0.1]) by mx08-00376f01.pphosted.com (8.17.1.22/8.17.1.22) with ESMTP id 38Q7o2bQ000911 for ; Tue, 26 Sep 2023 12:07:25 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=imgtec.com; h= from:to:subject:date:message-id:content-type:mime-version; s= dk201812; bh=KMsJDM0BMFEs2RNXmLbeSASFOVgneeV/gIgTsYqBMZs=; b=ihu y35Y6199FHoREzk4LW7BERPnU0a73lRSxC/UmMsBsi33+YNNV6tG1NQuhF0RmTTG usmSUZmkY0ix7daJMb1yCIht2unOJsA6X/bzoKCQFUTIs4hkunC313s5IDOlXacs 1VMM7iHfm5gimc8d47fep4B7OP3KqpUMeVneTtR+r26cGsN8hQowqBPVsEGiD54z VRyk9FhWbEYrABpoRVvNNB168EcQjhaFmqZVOjLCNDP2gsPwN8msXFdow84IeyeF B/fIJpkxSL4ru/ZaTQ6JpFdryW1UIWuzpjJUG8Yjnfi9d2TYMsFpfMbvUVJvMIr6 hru2sgelCEktCbaScMQ== Received: from hhmail05.hh.imgtec.org ([217.156.249.195]) by mx08-00376f01.pphosted.com (PPS) with ESMTPS id 3t9p9p2a1b-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 26 Sep 2023 12:07:25 +0100 (BST) Received: from HHMAIL04.hh.imgtec.org (10.100.10.119) by HHMAIL05.hh.imgtec.org (10.100.10.120) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Tue, 26 Sep 2023 12:07:11 +0100 Received: from GBR01-CWX-obe.outbound.protection.outlook.com (104.47.85.41) by email.imgtec.com (10.100.10.121) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31 via Frontend Transport; Tue, 26 Sep 2023 12:07:11 +0100 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q3kQA9CHlexU9IJOrd9xVvmET9kn8PM/UPduJuNGPsbgOHO11TR83/k+EHXElk8srD21Uu1dPeonD38QapmV6JtjD17PH1OdKhzBoreVqOgDTg3zUHBa4A9TWbu4sdqIfZlMnYKg3/ZKgF0ge/wpdJ5xDza9lSTuLVd8bDx/Z4UPklSSMUI9hv3LfChD6LBGOC0UwQVuNMaqa3vNiPnGGYKhbJaS6BQhnkF1FOZvMkB9K6nPnOrzg0IzeUiFMCbCcLVPKdQ7GxslkkScB50lKkKbj6xyo3vAoLq3qfLt1iToPeBwqufduueVOa6Br5/wkfEeiSCjoyqVQ/aGY8Cosg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KMsJDM0BMFEs2RNXmLbeSASFOVgneeV/gIgTsYqBMZs=; b=NC91q/2FnHOMm53YcJwS/fF3joMM5L2+5GBIlenfYHEKFRE71C6ZvCnbd1/SDSTnMk35wtmsKZowtZ3A5ivLQTLz3TP7Qwz+Gyf9J2d2cJDzdPzQaiF94cds4XdOGhNHAu8j5jyL5qmNQM4o3jbZJTjIeNVSJ0W7mdGZr6iL6B7c0ew/MXn38yXV02r5WNCSY4u2a4t4yyxvOhqDInQI4wGk0WUI04tJtidxYxc1ztifgHXy8tr315512fcOgZPgWfPTnD1J92X83csPzWg0zeAFWvqsSZWgAY4GmJb/XG/gETkOwiURAZ/uEZDWHy4kkFhurI6+OGurG2Wb24nr0g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=imgtec.com; dmarc=pass action=none header.from=imgtec.com; dkim=pass header.d=imgtec.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=IMGTecCRM.onmicrosoft.com; s=selector2-IMGTecCRM-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KMsJDM0BMFEs2RNXmLbeSASFOVgneeV/gIgTsYqBMZs=; b=JbqUvq5LEblsgg1WDZ5pbcsmItzlvhbjwv6IopHt8deMjxdn/3jnvEHov8mopk9Z6OP/3UNGSpn9m2PNwAiqMyfRAuCNKPWPCYF0TrCXdnxmlfY7ohI+tW6AFGCOVJxDEgDydePBQB5d5YfxFtOrAJCNBz410awzxVHHtseAaxc= Received: from LO4P265MB5914.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:29f::11) by LOYP265MB2047.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:114::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6813.28; Tue, 26 Sep 2023 11:07:11 +0000 Received: from LO4P265MB5914.GBRP265.PROD.OUTLOOK.COM ([fe80::3fac:2722:f9cf:2f39]) by LO4P265MB5914.GBRP265.PROD.OUTLOOK.COM ([fe80::3fac:2722:f9cf:2f39%4]) with mapi id 15.20.6813.027; Tue, 26 Sep 2023 11:07:10 +0000 From: Joseph Faulls To: "newlib@sourceware.org" Subject: [PATCH 1/1] newlib: libm: fix complex atan for +/- 1 + 0i Thread-Topic: [PATCH 1/1] newlib: libm: fix complex atan for +/- 1 + 0i Thread-Index: AdnwaTdJham5JY5IQfile86zmuCWMQ== Date: Tue, 26 Sep 2023 11:07:10 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: LO4P265MB5914:EE_|LOYP265MB2047:EE_ x-ms-office365-filtering-correlation-id: d3365f18-9e7f-4cee-a18e-08dbbe80bb25 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: h2FoTHdTLuaxjoD6/ToaxWJJweVHXwiwQMVW+fMiv6iWpGiIkY3P8auXdMm0afkhmoPMCy0ThNQ/xGgaKrJuugnxCGPkWcEKTK9rP4O2m/FWhnHxOP53qkOWPa3srhxsfxvQxjiTlcWilbWgSN2ifpOdcdCqFb6yZBQqrBLR0r09+RG3r4BLMUzNx4MrGdAYhJQoPwA4Unq/TxWzTbQFDwqz+QdgUbQyOIvol3z8YsPzDhV4/XauIE7ia9RdYIbE/nzbAg/qRx2nh69KZBnDcd5MJAjCgL62O1ja87J3DHpsnNg10NPg1Q1v710Pi1wK3jK793ufOToT1yb6Cc9ywuvR2n30u5GVyVJSTETL0ft/K6oDli+/Pl8qC+fbVkamuxe1B/dOax9wC9aAJohR6RgyI65d1x56SDUnHn9TyeHfEmQycGxxU7cuIh99ZECfhkt+plHbnut9n1I2CdYJqNNWpr2LHwVdqzbEUPXvPV/RChXqsvFhWnYdeq96O1bhnOVsLe3f79+eg7UCdhuPL1MozIrFBoTLhobpwvTV3r3Af2YwAOSNuFBfEkOplfBgalYT9U8f53A3aZIo4LdiCOZI1D67Jh+WJ1KAaqU6SZGsDsTN6Mx1egecUkhZ2pR8 x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:LO4P265MB5914.GBRP265.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230031)(396003)(376002)(366004)(39850400004)(346002)(136003)(230922051799003)(451199024)(1800799009)(186009)(8676002)(8936002)(55016003)(26005)(52536014)(2906002)(4744005)(478600001)(66476007)(41300700001)(76116006)(316002)(6916009)(66446008)(66946007)(66556008)(5660300002)(64756008)(6506007)(7696005)(71200400001)(9686003)(83380400001)(33656002)(38070700005)(122000001)(86362001)(38100700002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?qHUhYbGq7vnuiFcL07R4nUkW+UL/bThxxb9gWNRM+RJ7M8LG8YybRaCJ6LMN?= =?us-ascii?Q?FhE7Yo3hEvm1MmYs+qRrAI9sJ3tL5AlicF1tBb4/+NEG9iceLXdgo24mt1c5?= =?us-ascii?Q?7EJOWjXhIyqWMS8PY2AS/DuRRHaVODQSYjoBcJYnBhnvrZwpbTNTKChwFsj3?= =?us-ascii?Q?pY7jAITPZOEdx3gT48f8ZKirExoo+h06b7ZZZ++dY/0AxeDcArelfVa9nGXU?= =?us-ascii?Q?XyUDSWTGqwiQbiudrX5lv1nyw2/ksKfUWiEzQj6z1peRyrvAxNsf0PMb1hwL?= =?us-ascii?Q?VXIj6EIqUYdTnPu6AZENdUEZz55OBjecN3penaQuHg8IKJqvPNaUmeXtZVhN?= =?us-ascii?Q?K9dyhhBoFVQAWFCaSOqSRULagONSMh3INdw/ex2Te4QAyjZROm7qPEj6adWu?= =?us-ascii?Q?21Qe/epNdjNgeW2YbxYNyqpyHgfFdykHf6sXQeX2s/uurJUkZbrfNVCvCm2y?= =?us-ascii?Q?q3wJvVkqNNk2H5WCEsm4RjMG9jp8ga3dhJzuQJAx07rYI+lBv1ZtFuSpXs/H?= =?us-ascii?Q?S0Yh45O/TSw0+wu0WcL42lqk2zGV+9KB3rufbBPkkZyNMhR4F46W9y252Rut?= =?us-ascii?Q?FzRnp3on/SDZ/RRP+MB3qctyGcXW9zz3beCLp2qvhhuiPnWL9q+BB+dtd+xw?= =?us-ascii?Q?uDgVbaCRlYayxTWuECTUEfsXfL3orukz71c3DVyhsoeOQKVLB1rwF2bzTz1T?= =?us-ascii?Q?ZL2HjVvuoatqy2Cg6GLLYvDgUkbvj194cvJvgBaeqSlkerPihUo4Jtcb83bL?= =?us-ascii?Q?Fd8T2B/lBOoS7IRZLkSG7GgtGMC5/AmRLQ50fhDOPWu/Y+8tqiAV7nIexhD8?= =?us-ascii?Q?AHIGImja+3B3bTOceroYeF/Wpsom4sdf1fP6SicKjfeUlRgycguX3E98Lyto?= =?us-ascii?Q?pmggsEtMZwpTwQztBZiSLwNpwOYvqL5BiYxdXs2qg+BuHqZ8/M1xGSx8e1/F?= =?us-ascii?Q?Zypdkt2LF8lZ64H2eJlR7BoilmK+yCVzDleY5gcjN0oxPAdTk9WxZAC0dofl?= =?us-ascii?Q?G6aJqU7cA9J8w16IBQ81jAYWA3PpMjQOmGImodFgVTit5g0/8FSAwEuKrc5d?= =?us-ascii?Q?v9LmLdXn1pxkV9yBKLxf2TzUXJhjs4l3KqdeQinu+41jPbtMcSS8AeBs60hq?= =?us-ascii?Q?8DZf5zMu/JURf49pt1j2C39d7Qwx/O0QX5Mh8e1gI10bdJ+JP4niObkVueVj?= =?us-ascii?Q?yyRM5QnHEExZdyIibJfqSMGSQhE2HZfz9gGff7CO/TdCTgKqKgIAecicnYDD?= =?us-ascii?Q?HjGwnuzCbk4FsCNjILEAyfRnqrjxfa+Kc1Wx3tczmQk5nCaJ0oLTBBppAHmo?= =?us-ascii?Q?nzUDFsAauR3XFmEGVwuajabZRztRfIWv9ywNaXsOTWWgLv/ox5Nye3+IfjjD?= =?us-ascii?Q?XOIMehnDmBS1KLOAI70QGBIwRNwnCEQPXzAavshTDqGDpqRPI0W6ififgku2?= =?us-ascii?Q?tCXl2JsFLNc1uVV/NYzI3pQ7T3k2kaGM1VOzWZJwgO+SV2e32VYCyWPbFRnC?= =?us-ascii?Q?oiwxQaGRoWn1q38OWyicrVG31DAcIZQuxTI4SaFCNTkFHoi2OIWHrR/kNlkY?= =?us-ascii?Q?z+nFp5lyP7gCdP4zMpMI6jqmuvIXiBazvu1fW9Uz?= Content-Type: multipart/alternative; boundary="_000_LO4P265MB59145B0C9C2889DFD7498E5C80C3ALO4P265MB5914GBRP_" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: LO4P265MB5914.GBRP265.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: d3365f18-9e7f-4cee-a18e-08dbbe80bb25 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Sep 2023 11:07:10.7557 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 0d5fd8bb-e8c2-4e0a-8dd5-2c264f7140fe X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: gJw2rSYH2jtuAO3eGZIViIHy2FCh8HqQaNA2e/CKRSJY5hw81qFgbt7nLp5uLefQ4QRWIHHd/m1TmWigyLDfUBfaPafOPvffxUI0qEP93V0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: LOYP265MB2047 X-OriginatorOrg: imgtec.com X-EXCLAIMER-MD-CONFIG: 15a78312-3e47-46eb-9010-2e54d84a9631 X-Proofpoint-ORIG-GUID: -v6-1Fpcq7G9y8wTyR5N-ttK9o7Za8FW X-Proofpoint-GUID: -v6-1Fpcq7G9y8wTyR5N-ttK9o7Za8FW X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --_000_LO4P265MB59145B0C9C2889DFD7498E5C80C3ALO4P265MB5914GBRP_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Delete check which ensured atan2 was not called with x=3D0. This is not necessary as atan2 is defined for x=3D0 when y !=3D 0. The check incorrectly resulted in catan returning nan + inf i for when real part is +/- 1 and imaginary part is 0. The check could also have implications when called with imaginary number x + yi where x^2 + y^2 =3D=3D 1.0. Although this is unlikely due to floating point precision. --- newlib/libm/complex/catan.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/newlib/libm/complex/catan.c b/newlib/libm/complex/catan.c index 77510ec2f..34d75b849 100644 --- a/newlib/libm/complex/catan.c +++ b/newlib/libm/complex/catan.c @@ -105,8 +105,6 @@ catan(double complex z) x2 =3D x * x; a =3D 1.0 - x2 - (y * y); - if (a =3D=3D 0.0) - goto ovrf; t =3D 0.5 * atan2(2.0 * x, a); w =3D _redupi(t); -- 2.34.1 --_000_LO4P265MB59145B0C9C2889DFD7498E5C80C3ALO4P265MB5914GBRP_--