public inbox for newlib@sourceware.org
 help / color / mirror / Atom feed
From: Tamar Christina <Tamar.Christina@arm.com>
To: "newlib@sourceware.org" <newlib@sourceware.org>
Cc: nd <nd@arm.com>
Subject: Re: [PATCH][libgloss][semi-hosting] Preserve DESTDIR values for redirected builds.
Date: Mon, 17 Jul 2017 09:37:00 -0000	[thread overview]
Message-ID: <VI1PR0801MB203144E915D9F7B45F47A45AFFA00@VI1PR0801MB2031.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <20170717090721.GC3345@calimero.vinschen.de>

[-- Attachment #1: Type: text/plain, Size: 982 bytes --]

Ah, oops!

Sorry I, did make the format-patch version but then habit kicked in and I
sent the normal patch!

Here's the correct one.

Thanks!
________________________________________
From: newlib-owner@sourceware.org <newlib-owner@sourceware.org> on behalf of Corinna Vinschen <vinschen@redhat.com>
Sent: Monday, July 17, 2017 10:07 AM
To: newlib@sourceware.org
Subject: Re: [PATCH][libgloss][semi-hosting] Preserve DESTDIR values for redirected builds.

Hi Tamar,

On Jul 17 08:14, Tamar Christina wrote:
> Hi All,
>
> This patch adds support for building in a different directory than the default output
> directory by preserving DESTDIR value in recursive calls.
>
> OK for master?
>
> PS. I do not have commit rights.
>
> Thanks,
> Tamar

Would you mind to send patches in `git format-patch' format?  Most
of the above text doesn't exactly qualify for a git log message ;)


Thanks,
Corinna

--
Corinna Vinschen
Cygwin Maintainer
Red Hat

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Support-building-in-a-different-directory-than-the-d.patch --]
[-- Type: text/x-patch; name="0001-Support-building-in-a-different-directory-than-the-d.patch", Size: 878 bytes --]

From 9b7ef6bd7d5b7174a37095581ae8e2bb38303e3a Mon Sep 17 00:00:00 2001
From: Tamar Christina <tamar.christina@arm.com>
Date: Mon, 17 Jul 2017 08:46:45 +0100
Subject: [PATCH] Support building in a different directory than the default
 output directory by preserving DESTDIR value in recursive calls.

Signed-off-by: Tamar Christina <tamar.christina@arm.com>
---
 libgloss/multi-build.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libgloss/multi-build.in b/libgloss/multi-build.in
index e2fd0807a..1403eb35e 100644
--- a/libgloss/multi-build.in
+++ b/libgloss/multi-build.in
@@ -45,7 +45,7 @@ multi-do:
 		    LIBCXXFLAGS="$(LIBCXXFLAGS)" \
 		    LDFLAGS="$(LDFLAGS)" \
 		    MULTIFLAGS="" \
-		    DESTDIR="" \
+		    DESTDIR="$(DESTDIR)" \
 		    SOURCE="${srcdir}/" \
 		    INSTALL="$(INSTALL)" \
 		    INSTALL_DATA="$(INSTALL_DATA)" \
-- 
2.13.0


  reply	other threads:[~2017-07-17  9:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-17  8:14 Tamar Christina
2017-07-17  9:07 ` Corinna Vinschen
2017-07-17  9:37   ` Tamar Christina [this message]
2017-07-17 11:43     ` Corinna Vinschen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=VI1PR0801MB203144E915D9F7B45F47A45AFFA00@VI1PR0801MB2031.eurprd08.prod.outlook.com \
    --to=tamar.christina@arm.com \
    --cc=nd@arm.com \
    --cc=newlib@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).