From: Tamar Christina <Tamar.Christina@arm.com>
To: "newlib@sourceware.org" <newlib@sourceware.org>
Cc: nd <nd@arm.com>
Subject: [PATCH][libgloss] Use POSIX regex character classes instead of perl regex classes
Date: Thu, 06 Jul 2017 12:22:00 -0000 [thread overview]
Message-ID: <VI1PR0801MB20314F91D9801EA2AC1554D0FFD50@VI1PR0801MB2031.eurprd08.prod.outlook.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 397 bytes --]
Hi All,
This fixed the build on systems using BSD sed instead of GNU sed where the semihosting
build would fall over because the sed expression wouldn't match.
The previous patch used perl style character classes for space \s while the new one
uses the POSIX style [:space:] instead.
OK for master?
PS. I don't have commit rights so if OK can someone commit for me?
Thanks,
Tamar
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Replace-the-perl-character-classes-with-POSIX-ones-t.patch --]
[-- Type: text/x-patch; name="0001-Replace-the-perl-character-classes-with-POSIX-ones-t.patch", Size: 1369 bytes --]
From 20e021656e96e28c9bdd81b7dac423961f340c75 Mon Sep 17 00:00:00 2001
From: Tamar Christina <tamar.christina@arm.com>
Date: Thu, 6 Jul 2017 10:33:31 +0100
Subject: [PATCH] Replace the perl character classes with POSIX ones to fix the
build when sed is a BSD sed instead of GNU.
Signed-off-by: Tamar Christina <tamar.christina@arm.com>
---
libgloss/multi-build.in | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/libgloss/multi-build.in b/libgloss/multi-build.in
index 0bd12cfd9..e2fd0807a 100644
--- a/libgloss/multi-build.in
+++ b/libgloss/multi-build.in
@@ -20,10 +20,10 @@ multi-do:
cp config.status $${destpre}; \
cd $${destpre}; \
$(SHELL) config.status; \
- sed -e "s:^MULTIDIRS\s*+=.*$$:MULTIDIRS = :" \
- -e "s:^MULTILIBNAME\s*=.*$$:MULTILIBNAME = MULTIDIR_$${dir}_NAME:" \
- -e "s:^MULTI_FLAGS_FOR_TARGET\s*=.*$$:MULTI_FLAGS_FOR_TARGET = MULTIDIR_$${dir}_FLAGS:" \
- -e "s:^objdir\s*=.*$$:objdir = ..:" \
+ sed -e "s:^MULTIDIRS[[:space:]]*+=.*$$:MULTIDIRS = :" \
+ -e "s:^MULTILIBNAME[[:space:]]*=.*$$:MULTILIBNAME = MULTIDIR_$${dir}_NAME:" \
+ -e "s:^MULTI_FLAGS_FOR_TARGET[[:space:]]*=.*$$:MULTI_FLAGS_FOR_TARGET = MULTIDIR_$${dir}_FLAGS:" \
+ -e "s:^objdir[[:space:]]*=.*$$:objdir = ..:" \
Makefile > Makefile.tem; \
rm -f Makefile; \
mv Makefile.tem Makefile; \
--
2.13.0
next reply other threads:[~2017-07-06 12:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-06 12:22 Tamar Christina [this message]
2017-07-06 16:36 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR0801MB20314F91D9801EA2AC1554D0FFD50@VI1PR0801MB2031.eurprd08.prod.outlook.com \
--to=tamar.christina@arm.com \
--cc=nd@arm.com \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).