From: Tamar Christina <Tamar.Christina@arm.com>
To: "newlib@sourceware.org" <newlib@sourceware.org>
Cc: nd <nd@arm.com>, Richard Earnshaw <Richard.Earnshaw@arm.com>,
"nickc@redhat.com" <nickc@redhat.com>
Subject: [PATCH][libgloss][AArch64] Fix flags for crt0 compilation.
Date: Fri, 21 Jul 2017 08:28:00 -0000 [thread overview]
Message-ID: <VI1PR0801MB20319253F28457D8360AB47BFFA40@VI1PR0801MB2031.eurprd08.prod.outlook.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 814 bytes --]
Hi All,
Previous patch to support nosys.specs accidentally broke
validation specs because ARM_RDI_MONITOR was never passed
to the build rule for crt0.
This fixed the compile for nosys and validation specs
but nosys won't run because of existing limitations to
aarch64's syscalls.c, it requires semihosting to get
commandline arguments and heap info without having a
fallback method as ARM does.
Tested on aarch64-none-elf with specs:
- nosys.specs
- aem-validation.specs
- rdimon.specs
Previously patch was only tested with qemu, which seems
is always able to write to the std handles. So also
cross-checked with aem this time.
Ok for master?
Ps. I don't have commit right.
Thanks (sorry for the repeated fixes. All build system configurations should have caught up now.),
Tamar
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Previous-patch-to-support-nosys.specs-accidentally.patch --]
[-- Type: text/x-patch; name="0001-Previous-patch-to-support-nosys.specs-accidentally.patch", Size: 1302 bytes --]
From e119b6c7ceca2ecef397002537fbc4208af1b93c Mon Sep 17 00:00:00 2001
From: Tamar Christina <tamar.christina@arm.com>
Date: Thu, 20 Jul 2017 13:28:40 +0100
Subject: [PATCH] Previous patch to support nosys.specs accidentally broke
validation specs because ARM_RDI_MONITOR was never passed to the build rule
for crt0.
This fixed the compile for nosys and validation specs
but nosys won't run because of existing limitations to
aarch64's syscalls.c, it requires semihosting to get
commandline arguments and heap info without having a
fallback method as ARM does.
Signed-off-by: Tamar Christina <tamar.christina@arm.com>
---
libgloss/aarch64/Makefile.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libgloss/aarch64/Makefile.in b/libgloss/aarch64/Makefile.in
index 546557e3c..8111f262c 100644
--- a/libgloss/aarch64/Makefile.in
+++ b/libgloss/aarch64/Makefile.in
@@ -118,7 +118,7 @@ test:
#
crt0.o: crt0.S
- $(CC) $(CFLAGS_FOR_TARGET) $($(MULTI_FLAGS_FOR_TARGET)) $(CFLAGS) $(INCLUDES) -o $@ -c $<
+ $(CC) $(CFLAGS_FOR_TARGET) $($(MULTI_FLAGS_FOR_TARGET)) $(CFLAGS) $(INCLUDES) -DARM_RDI_MONITOR -o $@ -c $<
rdimon-crt0${${MULTILIBNAME}}.o: crt0.S
$(CC) $(CFLAGS_FOR_TARGET) $($(MULTI_FLAGS_FOR_TARGET)) $(CFLAGS) $(INCLUDES) -DARM_RDI_MONITOR -o $@ -c $<
--
2.13.0
next reply other threads:[~2017-07-21 8:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-21 8:28 Tamar Christina [this message]
2017-07-21 8:50 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR0801MB20319253F28457D8360AB47BFFA40@VI1PR0801MB2031.eurprd08.prod.outlook.com \
--to=tamar.christina@arm.com \
--cc=Richard.Earnshaw@arm.com \
--cc=nd@arm.com \
--cc=newlib@sourceware.org \
--cc=nickc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).