From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 8C8323858D20 for ; Mon, 20 Feb 2023 09:45:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8C8323858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676886330; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=C5QmCe62xiNDhXICNwnLKGR34hK0kpCHhi/UcXaulWk=; b=DCuz7K0VswiQ90pg5kHWdsFzXKUyMAowOZaZV0CJS5dTZdygXBL3GsAKgJN6RKtLvmQCEz 2+dP2z9vBmmpPETPy/V6UFGl+Crjsv6MyQ8dVCMOIyLVu1tZ0kR+zwJJ6KP4LqfmOMRDli RiGqdAFa9YfW3i/7pNNTAhfdcQ4XheY= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-61-xkNVIKPKO_2h4NCA3zqMGQ-1; Mon, 20 Feb 2023 04:45:26 -0500 X-MC-Unique: xkNVIKPKO_2h4NCA3zqMGQ-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9E9E9811E6E; Mon, 20 Feb 2023 09:45:26 +0000 (UTC) Received: from calimero.vinschen.de (unknown [10.39.192.118]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7AA21492B00; Mon, 20 Feb 2023 09:45:26 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id 1181FA809BA; Mon, 20 Feb 2023 10:45:25 +0100 (CET) Date: Mon, 20 Feb 2023 10:45:25 +0100 From: Corinna Vinschen To: Brian Inglis Cc: newlib@sourceware.org Subject: Re: [PATCH 0/2] newlib/libc/time/strftime: table format fix man, tbl, groff multi-page table issues Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: Brian Inglis , newlib@sourceware.org References: <20230217204902.3735-1-Brian.Inglis@Shaw.ca> MIME-Version: 1.0 In-Reply-To: <20230217204902.3735-1-Brian.Inglis@Shaw.ca> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Brian, On Feb 17 13:49, Brian Inglis wrote: > Brian Inglis (2): > newlib/libc/time/strftime.c: split table of conversion > specifiers to fix man, tbl, groff multi-page table issues > newlib/libc/Makefile.inc: sed fix strftime.3 table format > man, tbl, groff multi-page issues > > newlib/libc/time/strftime.c | 3 ++- > newlib/libc/Makefile.inc | 1 + > 2 files changed, 3 insertions(+), 1 deletion(-) > > -- > 2.39.0 Would you mind terribly to add more text to the commit messages? explaining the problem, and its fix? Just the subject line is quite terse. For patch 1, why adding the split and what's the desired effect. For patch 2, what problem is the sed call fixing and what is the sed expression doing? Thanks, Corinna