From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id C3E45386481A for ; Mon, 20 Feb 2023 09:47:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C3E45386481A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676886448; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=qu+Pze3G2ZdyE9Vif9L30YvJ+9OdD6V/XPX63LlcRJ4=; b=PskWUk3AOEQLN8PW1pekRoTlaluGgBJLym6Nlz91qWXlH5EW/u9cMT9s48JiHaIDc0RrBk 13zhyS6r0CtXai10/PLqU7jyczLKunEbY1rSKlnKGcHKz9XklEMJX4n3VWlfLm6li3yafF DQDYZAbbOEpbaUKfwX7/dxxzRBCOUdk= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-330-bWQN7C2rNdOGNP5M_QTDYA-1; Mon, 20 Feb 2023 04:47:27 -0500 X-MC-Unique: bWQN7C2rNdOGNP5M_QTDYA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DD2873C02B6C for ; Mon, 20 Feb 2023 09:47:26 +0000 (UTC) Received: from calimero.vinschen.de (unknown [10.39.192.118]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BCF51404CD84 for ; Mon, 20 Feb 2023 09:47:26 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id AFBAEA809BA; Mon, 20 Feb 2023 10:47:25 +0100 (CET) Date: Mon, 20 Feb 2023 10:47:25 +0100 From: Corinna Vinschen To: newlib@sourceware.org Subject: Re: [PATCH 1/2] newlib/libc/ctype/mkcaseconv: fix POSIX shell invalid == comparison Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org References: <20230217205625.7454-1-Brian.Inglis@Shaw.ca> <24e9a91bbdec91f63440bd2ab5c4d47a9ff73166.1676518063.git.Brian.Inglis@Shaw.ca> MIME-Version: 1.0 In-Reply-To: <24e9a91bbdec91f63440bd2ab5c4d47a9ff73166.1676518063.git.Brian.Inglis@Shaw.ca> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-11.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Feb 17 13:56, Brian Inglis wrote: > --- > newlib/libc/ctype/mkcaseconv | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/newlib/libc/ctype/mkcaseconv b/newlib/libc/ctype/mkcaseconv > index ab0571d8fa03..a455aed16ef6 100755 > --- a/newlib/libc/ctype/mkcaseconv > +++ b/newlib/libc/ctype/mkcaseconv > @@ -89,7 +89,7 @@ then > diff=-1 > } > item () { > - if [ "$1" == "#error" ] > + if [ "$1" = "#error" ] > then echo "$*" > return > fi > -- > 2.39.0 Pushed. Thanks, Corinna