From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id A2C0F38582A7 for ; Wed, 19 Oct 2022 16:14:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A2C0F38582A7 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666196064; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=GqbzYaNRDfLPXbYrcyZ9cA68+Uk6zqf9t1Y8tuFTjNc=; b=WdWKjQm+mySRhH7sFdsGs03G1aQ0b0vMi0Na7Hiy5WtPXfE2UCQz8g82xEvTVgJZzMbKTO K5aU9iSBjvenf7EB13UqmnXZmuiIodA9jWv513qm4snCyhZ0PVcpslMQSvn4kkQyCwBMuE JUvntysWRQnMvcMyxzPfA+ElfL87n4c= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-136-TMuGR1GkMB-V0f5xEcvgHg-1; Wed, 19 Oct 2022 12:14:21 -0400 X-MC-Unique: TMuGR1GkMB-V0f5xEcvgHg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B0793296A608; Wed, 19 Oct 2022 16:14:20 +0000 (UTC) Received: from calimero.vinschen.de (unknown [10.39.193.22]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8E88F40E2900; Wed, 19 Oct 2022 16:14:20 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id 21980A80C90; Wed, 19 Oct 2022 18:14:19 +0200 (CEST) Date: Wed, 19 Oct 2022 18:14:19 +0200 From: Corinna Vinschen To: Simon Cook Cc: newlib@sourceware.org Subject: Re: [PATCH] libgloss: riscv: Install machine/syscall.h Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: Simon Cook , newlib@sourceware.org References: <9e7b18f2-4c89-00e1-0a20-471ccc59624e@embecosm.com> MIME-Version: 1.0 In-Reply-To: <9e7b18f2-4c89-00e1-0a20-471ccc59624e@embecosm.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Simon, On Oct 19 13:04, Simon Cook wrote: > Hi Corinna, > > My understanding is Makefile.am includes riscv/Makefile.inc which is the > only file I manually edited, the Makefile.in changes were just those made > when I ran automake in the libgloss folder after the Makefile.inc change. Sorry, my bad, I didn't realise that when glancing at the patch. Still, unfortunately your patch doesn't apply. It seems whitespaces, especially leading TABs, are broken in your patch. I suspect your MUA is breaking things. Maybe you can check this and, if all else fails, just attach the patch to your mail? Thanks, Corinna