From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 276E03858C50 for ; Mon, 24 Oct 2022 12:07:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 276E03858C50 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666613239; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=p5ty4vIv32E6vSVtMNZm0rifylM8J0+3hTZSjGsf/G8=; b=fTKMLgUlTU9kS/nlpuwG9TQWNhEvhm93bsnZAGOLVBXUkB4FE2IDn7takJ8jgpLldNmC9Z fBEgvT+zGd86hvFyr1RAr9CglwaWEBZDdZN80U9Ke99xOrmZJLzO2flCbjBoUNkh64Ivaj 653quCwhgWHQ+OURd38WfLMTuiP8Gho= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-408-_Rpqw4Y1NJi6JbZydEdzCw-1; Mon, 24 Oct 2022 08:07:18 -0400 X-MC-Unique: _Rpqw4Y1NJi6JbZydEdzCw-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 14573382F1A6 for ; Mon, 24 Oct 2022 12:07:18 +0000 (UTC) Received: from calimero.vinschen.de (unknown [10.39.193.22]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E4CAA492B0A for ; Mon, 24 Oct 2022 12:07:17 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id 868F1A80CFE; Mon, 24 Oct 2022 14:07:16 +0200 (CEST) Date: Mon, 24 Oct 2022 14:07:16 +0200 From: Corinna Vinschen To: newlib@sourceware.org Subject: Re: [PATCH] strftime.c(__strftime): add %q, %v, tests; tweak %Z doc Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org References: <20221022051352.2723-1-Brian.Inglis@SystematicSW.ab.ca> MIME-Version: 1.0 In-Reply-To: <20221022051352.2723-1-Brian.Inglis@SystematicSW.ab.ca> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Brian, On Oct 21 23:13, Brian Inglis wrote: > + case CQ('v'): /* BSD/OSX/Ruby extension VMS/Oracle date format > + from Arnold Robbins strftime version 3.0 */ > + { /* %v is equivalent to "%e-%b-%Y", flags and width can change year ^^^^^ pad? > + format. Recurse to avoid need to replicate %b and %Y formation. */ Sorry for being a nag, but doesn't that introduce an incompatible change? The BSDs don't handle pad and width, they just call _fmt("%e-%b-%Y", ...). Or am I missing how the BSD function works? Corinna