From: Corinna Vinschen <vinschen@redhat.com>
To: newlib@sourceware.org
Cc: Sebastian Huber <sebastian.huber@embedded-brains.de>
Subject: Re: [PATCH] powerpc/setjmp: Fix 64-bit support
Date: Thu, 27 Oct 2022 18:09:52 +0200 [thread overview]
Message-ID: <Y1qtULgEVPi93YAI@calimero.vinschen.de> (raw)
In-Reply-To: <20221027071729.47233-1-sebastian.huber@embedded-brains.de>
On Oct 27 09:17, Sebastian Huber wrote:
> The first attempt to support the 64-bit mode had two bugs:
>
> 1. The saved general-purpose register 31 value was overwritten with the saved
> link register value.
>
> 2. The link register was saved and restored using 32-bit instructions.
>
> Use 64-bit store/load instructions to save/restore the link register. Make
> sure that the general-purpose register 31 and the link register storage areas
> do not overlap.
LGTM, but I'm not a PowerPC expert. If you tested it, feel free to push.
Thanks,
Corinna
prev parent reply other threads:[~2022-10-27 16:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-27 7:17 Sebastian Huber
2022-10-27 16:09 ` Corinna Vinschen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1qtULgEVPi93YAI@calimero.vinschen.de \
--to=vinschen@redhat.com \
--cc=newlib@sourceware.org \
--cc=sebastian.huber@embedded-brains.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).