From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 5BC403851526 for ; Thu, 27 Oct 2022 16:09:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5BC403851526 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666886999; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=7TkIFayCJlhyGRbQzryHs/20b+JAEhRM2iiaIw5v+GI=; b=KpfBKp3Sx4NJ7UCMGGeWVLCamGh5r7kYytWi6hhaNI8zkb/LApNJSuly2ytDZPKgTAF/s1 GmguqwAtcuh+Popzj/2NwIZ6YYOG91ztCOQ/rcPIdCT4zWgjtlPa5FJr9rOCXr8Xoz63vC m9CaY8zPjFWFVeDt0PPWC4okVg8tIXI= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-425-yHOyjKC2M4CgyhSVKXCpvA-1; Thu, 27 Oct 2022 12:09:57 -0400 X-MC-Unique: yHOyjKC2M4CgyhSVKXCpvA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A467529324B1; Thu, 27 Oct 2022 16:09:56 +0000 (UTC) Received: from calimero.vinschen.de (unknown [10.39.193.22]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6888C112131B; Thu, 27 Oct 2022 16:09:56 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id 6B985A807CD; Thu, 27 Oct 2022 18:09:52 +0200 (CEST) Date: Thu, 27 Oct 2022 18:09:52 +0200 From: Corinna Vinschen To: newlib@sourceware.org Cc: Sebastian Huber Subject: Re: [PATCH] powerpc/setjmp: Fix 64-bit support Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org, Sebastian Huber References: <20221027071729.47233-1-sebastian.huber@embedded-brains.de> MIME-Version: 1.0 In-Reply-To: <20221027071729.47233-1-sebastian.huber@embedded-brains.de> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Oct 27 09:17, Sebastian Huber wrote: > The first attempt to support the 64-bit mode had two bugs: > > 1. The saved general-purpose register 31 value was overwritten with the saved > link register value. > > 2. The link register was saved and restored using 32-bit instructions. > > Use 64-bit store/load instructions to save/restore the link register. Make > sure that the general-purpose register 31 and the link register storage areas > do not overlap. LGTM, but I'm not a PowerPC expert. If you tested it, feel free to push. Thanks, Corinna