From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id AAE4F3858C5E for ; Mon, 7 Nov 2022 16:33:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org AAE4F3858C5E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667838797; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=zlnsurAwP+tGIX4Nr4XCDgLzShADUB14hALe18vEWzE=; b=T4d5z8CJDFke7DTOBtfx3iuw6FXu6zJ3wPyYBq0NHBvqPvUCu8/Lo+KtHAJCNwGV1WMEVY 2M8afx8IP0hSXLiVAvsJfk1ksiOGiinvtCGTnRNdifFu4ad3ipvbkrdTfkNWJu8bEqXYVj 2l4KDeJ2i1RQIW2nbOHV/UwqchNCAYA= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-632--Ij7toAvMAGAuH32PNDP6Q-1; Mon, 07 Nov 2022 11:33:16 -0500 X-MC-Unique: -Ij7toAvMAGAuH32PNDP6Q-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CF9D5833AF3 for ; Mon, 7 Nov 2022 16:33:15 +0000 (UTC) Received: from calimero.vinschen.de (unknown [10.39.192.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AC73FC15BB5 for ; Mon, 7 Nov 2022 16:33:15 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id F16C4A8167A; Mon, 7 Nov 2022 17:33:12 +0100 (CET) Date: Mon, 7 Nov 2022 17:33:12 +0100 From: Corinna Vinschen To: newlib@sourceware.org Subject: Re: [PATCH] powerpc/setjmp: Fix 64-bit buffer alignment Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org References: <20221107154856.34249-1-sebastian.huber@embedded-brains.de> MIME-Version: 1.0 In-Reply-To: <20221107154856.34249-1-sebastian.huber@embedded-brains.de> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-10.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Nov 7 16:48, Sebastian Huber wrote: > The rlwinm is a word-size instruction which clears the remaining 32 bits of a > 64-bit register. Use clrrdi in 64-bit configurations. I'm getting a bit cross-eyed when looling at PowerPC assembler. I'm sure you tested it, so feel free to push. Thanks, Corinna > --- > newlib/libc/machine/powerpc/setjmp.S | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/newlib/libc/machine/powerpc/setjmp.S b/newlib/libc/machine/powerpc/setjmp.S > index 3a6fa4a58..c7af5b105 100644 > --- a/newlib/libc/machine/powerpc/setjmp.S > +++ b/newlib/libc/machine/powerpc/setjmp.S > @@ -8,11 +8,19 @@ > FUNC_START(setjmp) > #ifdef __ALTIVEC__ > addi 3,3,15 # align Altivec to 16 byte boundary > +#if __powerpc64__ > + clrrdi 3,3,4 > +#else > rlwinm 3,3,0,0,27 > +#endif > #else > addi 3,3,7 # align to 8 byte boundary > +#if __powerpc64__ > + clrrdi 3,3,3 > +#else > rlwinm 3,3,0,0,28 > #endif > +#endif > #if __SPE__ > /* If we are E500, then save 64-bit registers. */ > evstdd 1,0(3) # offset 0 > @@ -193,11 +201,19 @@ FUNC_END(setjmp) > FUNC_START(longjmp) > #ifdef __ALTIVEC__ > addi 3,3,15 # align Altivec to 16 byte boundary > +#if __powerpc64__ > + clrrdi 3,3,4 > +#else > rlwinm 3,3,0,0,27 > +#endif > #else > addi 3,3,7 # align to 8 byte boundary > +#if __powerpc64__ > + clrrdi 3,3,3 > +#else > rlwinm 3,3,0,0,28 > #endif > +#endif > #if __SPE__ > /* If we are E500, then restore 64-bit registers. */ > evldd 1,0(3) # offset 0 > -- > 2.35.3