From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 225593858D39 for ; Fri, 2 Dec 2022 17:10:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 225593858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670001046; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=HBfS3vP2NhWtWvQMwBe2dL2+Ykqu24xKsO+0M+LQYvc=; b=Ax7pQ6YDT9f8j+e6f16gb4h7kHa9CfFxXfTHPvXsVkqdS3LZfxzGAFS3OIcz+cNMOCyBxs +pRY3KUbOzV6pBwh1jwLW7pq0G7CSg7Kua6Q6hzPyrRu5opCHmU+ZaEUFkSoqVdtNwVC05 1QdQiLo2sM5LIfizfTkb6FuLi2qceMY= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-382-BdfXSqTkNA-mnFGOWn4vXg-1; Fri, 02 Dec 2022 12:10:45 -0500 X-MC-Unique: BdfXSqTkNA-mnFGOWn4vXg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 46A29185A79C; Fri, 2 Dec 2022 17:10:45 +0000 (UTC) Received: from calimero.vinschen.de (unknown [10.39.192.219]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3C9331401C39; Fri, 2 Dec 2022 17:10:44 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id 11FAEA80891; Fri, 2 Dec 2022 18:10:41 +0100 (CET) Date: Fri, 2 Dec 2022 18:10:41 +0100 From: Corinna Vinschen To: Joel Sherrill Cc: newlib@sourceware.org, Jeff Johnston Subject: Re: Adding aio.h and mqueue.h Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: Joel Sherrill , newlib@sourceware.org, Jeff Johnston References: MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Dec 2 08:15, Joel Sherrill wrote: > On Fri, Dec 2, 2022 at 4:07 AM Corinna Vinschen wrote: > > > On Dec 1 18:22, Jeff Johnston wrote: > > > As long as the licensing is shared-newlib-compatible (non-GPL), it should > > > be ok. > > > > > > -- Jeff J. > > > > Cygwin already comes with aio.h and mqueue.h headers. > > > > Ideally they are reused for newlib, or the new aio.h/mqueue.h headers > > are checked that they provide the same definitions and replace the > > Cygwin-only ones. > > > > OK. So the same defines with the same values? Anything cygwin specific > goes into an ifdef, etc. I vaguely recall doing this before for other > header files. There shouldn't be much Cygwin-specifc in these files and they are quite short. Please check the Cygwin files against the files from RTEMS. Maybe it makes sense to use them instead and just add the (minor) differences to Cygwin. If the types used have the same size and the same signedness, there shouldn't be much of a problem anyway. However, I'd like to defer this by a few days or weeks. We're just in the beta phase for Cygwin 3.4, and I would rather have stable headers for now :} Thanks, Corinna