From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 13AF73E221C5 for ; Mon, 19 Dec 2022 09:39:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 13AF73E221C5 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1671442798; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=3EZG019Z3vAMbAlScf+TpnrUNqN0Q4iCgpowb4NpjT4=; b=IibGe48cD300CC1HaI+oEhyA9El0OvsbyWuwYlJQkUaI1TNWf/Ao1ehZu5dq0WDEzPcvax TTOLVntmVH66gATFEahlzJ92RZSyqVixQwjCaK+ZqiyYP92pefIDsSjKiVXPL+swJEht6Z 61dlmnk+56K+0cFUGs5MPf33mcO8xw0= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-148-rKqcAJBDOaWo3bL-2EPsVQ-1; Mon, 19 Dec 2022 04:39:57 -0500 X-MC-Unique: rKqcAJBDOaWo3bL-2EPsVQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D9F8E8027F8 for ; Mon, 19 Dec 2022 09:39:56 +0000 (UTC) Received: from calimero.vinschen.de (unknown [10.39.193.230]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B48EC1121314 for ; Mon, 19 Dec 2022 09:39:56 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id 67B79A80B9B; Mon, 19 Dec 2022 10:39:55 +0100 (CET) Date: Mon, 19 Dec 2022 10:39:55 +0100 From: Corinna Vinschen To: newlib@sourceware.org Subject: Re: [PATCH] Fix a bug in setjmp for MIPS o32/o64 FPXX/FP64 Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org References: <20221217144723.84653-1-rasky@develer.com> MIME-Version: 1.0 In-Reply-To: <20221217144723.84653-1-rasky@develer.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-10.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Dec 17 15:47, Giovanni Bajo wrote: > It seems there is a swapped logic in one of the subcases of > setjmp.S for MIPS: when the FPU registers are 64-bit within > a 32-bit aligned jmp_buf, the code realigns the pointers > before doing 64-bit writes, but the branch logic is swapped: > we must avoid the address adjustement when bit 2 is zero > (that is, the address is already 8-byte aligned). > > This always triggers an address error when run, as tested > on a MIPS VR4300 with O64 ABI. > > --- > newlib/libc/machine/mips/setjmp.S | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/newlib/libc/machine/mips/setjmp.S b/newlib/libc/machine/mips/setjmp.S > index 9a8b31d09..cfc1d517a 100644 > --- a/newlib/libc/machine/mips/setjmp.S > +++ b/newlib/libc/machine/mips/setjmp.S > @@ -68,7 +68,7 @@ > > #define FPR_LAYOUT \ > and $8, $4, 4; \ > - bne $8, $0, 1f; \ > + beq $8, $0, 1f; \ > GPR_OFFSET ($31, 22); \ > addiu $4, $4, -4; \ > 1: \ > -- > 2.37.0 Pushed. Thanks, Corinna