From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (smtp.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id DF3883858421 for ; Wed, 21 Dec 2022 01:47:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DF3883858421 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org Received: by smtp.gentoo.org (Postfix, from userid 559) id C302C34167D; Wed, 21 Dec 2022 01:47:55 +0000 (UTC) Date: Tue, 20 Dec 2022 20:47:53 -0500 From: Mike Frysinger To: Richard Earnshaw Cc: newlib@sourceware.org Subject: Re: [PATCH] libgloss: arm: break newlib dependency Message-ID: References: <20221214091304.25170-1-vapier@gentoo.org> <7ca62fc8-618e-e213-92c1-195a9b55da1c@foss.arm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="hlN7cOzehuJ9KB4d" Content-Disposition: inline In-Reply-To: <7ca62fc8-618e-e213-92c1-195a9b55da1c@foss.arm.com> X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --hlN7cOzehuJ9KB4d Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 19 Dec 2022 10:08, Richard Earnshaw wrote: > On 14/12/2022 09:13, Mike Frysinger wrote: > > The libgloss port has been reaching back into newlib internals for a > > single header whose contents have been frozen for almost a decade. > > To break this backwards libgloss->newlib dependency, duplicate that > > header here so we can keep libgloss independent as it's meant to be. >=20 > This isn't really 'newlib internals', it's a header file that tries to=20 > provide ACLE[1] compatibility for older versions of GCC that lacked such= =20 > support. Having two copies of this is a maintenance burden, so I'm not= =20 > entirely sure this is a great thing to do, even if the copies are=20 > supposed to be identical. newlib already has 2 itself. so this will be a 3rd. i don't disagree with the maintenance concern, but the fact the file hasn't changed in a decade, and seems unlikely to ever change, makes me not worry about it. > If we can agree on a common location in the source tree that both newlib= =20 > and libgloss can pull this from, then I'm happy to move it if that would= =20 > make you happier. libgloss is supposed to be C library agnostic. the C library (newlib) itse= lf relies on the output of libgloss (e.g. the crt and low level syscalls). si= nce there is no other tree/project in play that i'm aware of, that means there = are really only three options: * have the compiler provide it * have libgloss provide it (and newlib uses that) * duplicate the header i know the libgloss/newlib separation is still pretty unclean due to the two projects historically being one (i.e. everything in newlib), but i don't th= ink that's a good reason to keep it messy with libgloss depending on newlib. -mike --hlN7cOzehuJ9KB4d Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmOiZckACgkQQWM7n+g3 9YH8jxAAuJRDQO4LXBFiJH+OnJlH92sENsUgp5Zf3w4ADUUGBjTGa7ERklljMeeE y/J7jXfQw7uL57hznmuOZizbBBOsbnn6uvlQuoXowoF8fe26hD7oaTs13mm8F819 9m9Pks8Qb2twbHQTjTNzAjyLuGMLaqo0kbwXlAo/pHydpKdAiCceV/tAggDdRn8U skZupKLvdVSwiaAUAJDXoOA6+ZsolA8jN1FhauIy6laTRSRlMsWx4xUrc+pENMHm 59UDatkEaFKj9eisKNc7ADEPqcRFhhKgdM6avoXgIyDbB+xv1EsukF9SC33bo75N ts1oDCXsW9wSVcdpE+EqxnZJGffuZz4iTfIP5v+NpIfauRZK949t5jMNbTPLGi/6 g/uXJBs6B4dzny8YvSE0UMSqZxGob1I3p4SdwhThkc2pdqwoE+jeVf0qXeqlPgdj p4/zvuoM7wGfmcGZNjrWXuZUGzN8DHYrEl87C6WFITCPJDuEtyowOQyy6Reggz59 6y1ADcitXvDQrHeukxqb74jfeWAdD4vLodvfw4/clAnV9cKHMZo+Obc8nOuAbqgt fKeL/1xBT1MGmwBI63Y2nQK5flck9tRW9851BarZJzhykBI9aobP+qVl6Xg6fmJe tNbeEo9aY/66HOxmKn4qs7jEBWHjJZZzGNgCAH56bZcVW8Zl7HM= =sVI5 -----END PGP SIGNATURE----- --hlN7cOzehuJ9KB4d--