From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id 4946538493F2 for ; Thu, 22 Dec 2022 22:03:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4946538493F2 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org Received: by smtp.gentoo.org (Postfix, from userid 559) id C5FA833BF51; Thu, 22 Dec 2022 22:03:42 +0000 (UTC) Date: Thu, 22 Dec 2022 17:03:40 -0500 From: Mike Frysinger To: Richard Earnshaw , newlib@sourceware.org Subject: Re: [PATCH] libgloss: arm: break newlib dependency Message-ID: References: <20221214091304.25170-1-vapier@gentoo.org> <7ca62fc8-618e-e213-92c1-195a9b55da1c@foss.arm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Ml757COtOfMPKTTV" Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --Ml757COtOfMPKTTV Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 21 Dec 2022 09:24, Corinna Vinschen wrote: > On Dec 20 20:47, Mike Frysinger wrote: > > On 19 Dec 2022 10:08, Richard Earnshaw wrote: > > > On 14/12/2022 09:13, Mike Frysinger wrote: > > > > The libgloss port has been reaching back into newlib internals for a > > > > single header whose contents have been frozen for almost a decade. > > > > To break this backwards libgloss->newlib dependency, duplicate that > > > > header here so we can keep libgloss independent as it's meant to be. > > >=20 > > > This isn't really 'newlib internals', it's a header file that tries t= o=20 > > > provide ACLE[1] compatibility for older versions of GCC that lacked s= uch=20 > > > support. Having two copies of this is a maintenance burden, so I'm n= ot=20 > > > entirely sure this is a great thing to do, even if the copies are=20 > > > supposed to be identical. > >=20 > > newlib already has 2 itself. so this will be a 3rd. i don't disagree = with > > the maintenance concern, but the fact the file hasn't changed in a deca= de, > > and seems unlikely to ever change, makes me not worry about it. > >=20 > > > If we can agree on a common location in the source tree that both new= lib=20 > > > and libgloss can pull this from, then I'm happy to move it if that wo= uld=20 > > > make you happier. > >=20 > > libgloss is supposed to be C library agnostic. the C library (newlib) = itself > > relies on the output of libgloss (e.g. the crt and low level syscalls).= since > > there is no other tree/project in play that i'm aware of, that means th= ere are > > really only three options: > > * have the compiler provide it > > * have libgloss provide it (and newlib uses that) > > * duplicate the header > >=20 > > i know the libgloss/newlib separation is still pretty unclean due to th= e two > > projects historically being one (i.e. everything in newlib), but i don'= t think > > that's a good reason to keep it messy with libgloss depending on newlib. >=20 > Why not just /include then? It already contains target-specific > stuff in the opcodes subdir, or the xtensa headers. Having to share them > between newlib and libgloss should be reason enough to move the file ther= e. the file is currently installed under machine/. none of the installed head= ers use it though, so maybe it doesn't really need to be installed. if that's = the case, moving it into the top-level include/ would work. -mike --Ml757COtOfMPKTTV Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmOk1DwACgkQQWM7n+g3 9YEghRAAvZz5WZB+HhGWZNaO/cWmZTyd2GWebXr6H4mTq3jVVGjTIcaDX+S5FI1C f1DM8b8adZkytK5pbJRLstufFidDIskOrhCsIj3tprqwD7Z27NkfE8+xmrsY/lNG kqviOK5kFNfGScRB6nVpOVIFE3x0YS/lriF+Qg0xYV5kdhyl2bCQ1VmG8OJg06M3 tciVytUMcUQrhrtI2Adhq0pwfQMTaDDjA8KQdL7L6h6H5S0l+JSta/nxv3ZTIsn+ mOeK2EyFhu3WbjnwLMo4U2SZYP4UXGrOktA56me+iziu0EfnzIizLjPyU5FABhYx rpzdvhlQIP6lTAar0//xHcuDNEXk6rzAgpiGNPWyXduGidDeEDRZVX8G2c5oDfW6 Hcn1DJfbBdcgzYbOdUa4GUe5J1jLHMT5N+W05xoyL9BYSx+VwHloPGFSv/oXGYoH dpfpxZy8EYKAcSG8XSfaT6pk5HJ9hwcsSADcG/JbhgdP34saGg3q3SaQGBaN2jgH rvBHysRLQMw8/LgQKo/Ogx3ReYEq3UyShwxW4XPTCgWKfR77WYz143njBx2jFFZp ur7KKZvg6XJ2ckCsyvtrfbnUVILz9hQBQEezglGffdTnabA2Tolq65Czdrl3HJSr 93lxIvzTwBIjwJO8XB7Ns74XdFPtPPgYcjrh17seIBfV0DIlH7g= =a+1f -----END PGP SIGNATURE----- --Ml757COtOfMPKTTV--