From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 7D08B3858CDA for ; Wed, 11 Jan 2023 09:14:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7D08B3858CDA Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673428483; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=KE3eJEB+qxoe110Iv5S17EA9aAwwDKfXcRuD7eUM8xM=; b=LiV4mh7nb8FZIeRVKwO6UjZgrTSryPB/2sKeiH7gavSqKQeuVj5puJsH1wvkdx8Bf0/gMg p4wxd69kUXHYff6FoX5RjBIhrn501NqNJh9QODqStT91qc2A6r4oMZQFU+1ivQts62Oq2v 7qPMqm5DMIO9qj48hi4gsYF4iSM6gTQ= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-295-YUMePNTZPJatEhv6qTV9Bw-1; Wed, 11 Jan 2023 04:14:41 -0500 X-MC-Unique: YUMePNTZPJatEhv6qTV9Bw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3DCAA3C0D853 for ; Wed, 11 Jan 2023 09:14:41 +0000 (UTC) Received: from calimero.vinschen.de (unknown [10.39.193.197]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 180CF1121314 for ; Wed, 11 Jan 2023 09:14:41 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id C2FD4A809C8; Wed, 11 Jan 2023 10:14:39 +0100 (CET) Date: Wed, 11 Jan 2023 10:14:39 +0100 From: Corinna Vinschen To: newlib@sourceware.org Subject: Re: [PATCH v3] libgloss: arm: break newlib dependency Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org References: <20221214091304.25170-1-vapier@gentoo.org> <20230111060140.24696-1-vapier@gentoo.org> MIME-Version: 1.0 In-Reply-To: <20230111060140.24696-1-vapier@gentoo.org> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Jan 11 01:01, Mike Frysinger wrote: > The libgloss port has been reaching back into newlib internals for a > single header whose contents have been frozen for almost a decade. > To break this backwards libgloss->newlib dependency, move the acle > header to the srcroot include/ so everyone can use the same copy. > --- > v3 > - use -idirafter with srcroot > > .../arm-acle-compat.h | 0 > libgloss/Makefile.am | 3 + > libgloss/Makefile.in | 2 + > libgloss/arm/Makefile.in | 2 - > libgloss/arm/arm.h | 2 +- > libgloss/config/default.mh | 2 +- > newlib/Makefile.am | 3 +- > newlib/Makefile.in | 4 +- > newlib/libc/machine/arm/aeabi_memcpy-armv7a.S | 2 +- > newlib/libc/machine/arm/aeabi_memmove-thumb.S | 2 +- > newlib/libc/machine/arm/aeabi_memset-thumb.S | 2 +- > newlib/libc/machine/arm/arm_asm.h | 2 +- > newlib/libc/machine/arm/machine/acle-compat.h | 182 ------------------ > newlib/libc/machine/arm/memchr-stub.c | 2 +- > newlib/libc/machine/arm/memchr.S | 2 +- > newlib/libc/machine/arm/memcpy-stub.c | 2 +- > newlib/libc/machine/arm/memcpy.S | 2 +- > newlib/libc/machine/arm/setjmp.S | 2 +- > newlib/libc/machine/arm/strcmp.S | 2 +- > newlib/libc/machine/arm/strlen-armv7.S | 2 +- > newlib/libc/machine/arm/strlen-thumb2-Os.S | 2 +- > newlib/libc/machine/arm/strlen.S | 2 +- > newlib/libc/sys/arm/arm.h | 2 +- > 23 files changed, 25 insertions(+), 203 deletions(-) > rename newlib/libc/machine/arm/acle-compat.h => include/arm-acle-compat.h (100%) > delete mode 100644 newlib/libc/machine/arm/machine/acle-compat.h LGTM. Thanks, Corinna