From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 3395A3858D32 for ; Fri, 13 Jan 2023 10:11:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3395A3858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673604717; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=j7UCxqTEUUgBP/XMxq4ZZeHJdG9ihwxW6yZNjMMpjts=; b=BwEXkP3zQKlmCV3trWG5T+JkPW9nlonGKYOweMm5TGmkdGN6MsfFWcEo57AlntCc8jog8C Jkg51pzdB7ISTz86Erlcn6NtDoFxBCQ1CzHraphBb+3TCHywUQMAaDaD9ceYtX46nJgE7A kJUvR56m3mt7KpT5oaS4OZE9elfB2hg= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-262-nY5nyL3cNAGT3qME6q1rcg-1; Fri, 13 Jan 2023 05:11:54 -0500 X-MC-Unique: nY5nyL3cNAGT3qME6q1rcg-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 30BEC811E9C; Fri, 13 Jan 2023 10:11:54 +0000 (UTC) Received: from calimero.vinschen.de (unknown [10.39.193.197]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0B21E492B05; Fri, 13 Jan 2023 10:11:54 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id B151BA80B93; Fri, 13 Jan 2023 11:11:52 +0100 (CET) Date: Fri, 13 Jan 2023 11:11:52 +0100 From: Corinna Vinschen To: =?utf-8?B?556/5LuZ5re8?= Cc: newlib Subject: Re: [PATCH] libgloss: csky: use atexit to call fini-array functions. Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: =?utf-8?B?556/5LuZ5re8?= , newlib References: <20230110075927.1937-1-cooper.qu@linux.alibaba.com> <41528e9f-1b8c-4ca0-a2bd-1341e683dca8.xianmiao.qxm@alibaba-inc.com> MIME-Version: 1.0 In-Reply-To: <41528e9f-1b8c-4ca0-a2bd-1341e683dca8.xianmiao.qxm@alibaba-inc.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,BODY_8BITS,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Cooper, On Jan 13 10:07, 瞿仙淼 wrote: > Hi, > Could someone review this patch? This is a small change, I would > appreciate it if anyone would like to review. your original mail didn't make it to the newlib ML, I don't see this in the archives @ https://sourceware.org/pipermail/newlib/2023/ either. Can you resend your patch with `git send-email' or as attachment? But see below. > ------------------------------------------------------------------ > From:Xianmiao Qu > Sent At:2023 Jan. 10 (Tue.) 15:59 > To:newlib > Cc:Xianmiao Qu > Subject:[PATCH] libgloss: csky: use atexit to call fini-array functions. > __libc_fini_array should be called upon exit to call the > global termination functions in fini-array, use atexit to > register it at __start. There should be an empty line between the first and the second line of the commit message. The text up to the first blank line in a commit message is treated as the commit title and your message results in a multi line summary. Other than that, your patch looks goot to me. Thanks, Corinna