public inbox for newlib@sourceware.org
 help / color / mirror / Atom feed
From: Corinna Vinschen <vinschen@redhat.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: newlib@sourceware.org
Subject: Re: malloc() fails to compile with --enable-newlib-reent-thread-local
Date: Fri, 3 Feb 2023 13:11:53 +0100	[thread overview]
Message-ID: <Y9z6CX+Di5QvdiVn@calimero.vinschen.de> (raw)
In-Reply-To: <23548fc0-b5cb-8c3c-4a52-15a58c1da395@zytor.com>

On Feb  2 19:51, H. Peter Anvin wrote:
> Hi,
> 
> as of newlib-4.3.0 (git 9e09d6ed83cce4777a5950412647ccc603040409) malloc()
> fails to compile with the following options set:
> 
>         --disable-newlib-fseek-optimization \
>         --disable-newlib-fvwrite-in-streamio \
>         --disable-newlib-mb \
>         --disable-newlib-reent-check-verify \
>         --disable-newlib-register-fini \
>         --disable-newlib-supplied-syscalls \
>         --disable-newlib-unbuf-stream-opt \
>         --disable-newlib-wide-orient \
>         --enable-lite-exit \
>         --enable-target-optspace \
>         --enable-newlib-multithread \
>         --enable-newlib-global-atexit \
>         --enable-newlib-nano-formatted-io \
>         --enable-newlib-io-c99-formats \
>         --enable-newlib-reent-thread-local \
>         --enable-newlib-nano-malloc
> 
> (same effect without --enable-newlib-nano-malloc).
> 
> The reason is that the malloc() routines appear to hard-code the use of
> "reent_ptr->_errno" instead of using _REENT_ERRNO(), but if I'm not
> completely out to sea it really shouldn't be using "reent_ptr" at all,
> similar to the !_LIBC case?

Yeah, looks like it.  Patches welcome!


Thanks,
Corinna


      reply	other threads:[~2023-02-03 12:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-03  3:51 H. Peter Anvin
2023-02-03 12:11 ` Corinna Vinschen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y9z6CX+Di5QvdiVn@calimero.vinschen.de \
    --to=vinschen@redhat.com \
    --cc=hpa@zytor.com \
    --cc=newlib@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).