From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 1680C385702D for ; Wed, 17 Feb 2021 10:01:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 1680C385702D Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-293-d_hBrA8VOci8ktPRrziDwQ-1; Wed, 17 Feb 2021 05:01:44 -0500 X-MC-Unique: d_hBrA8VOci8ktPRrziDwQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A11ED1005501; Wed, 17 Feb 2021 10:01:43 +0000 (UTC) Received: from calimero.vinschen.de (ovpn-112-15.ams2.redhat.com [10.36.112.15]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6F91360843; Wed, 17 Feb 2021 10:01:43 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id BEC0EA80739; Wed, 17 Feb 2021 11:01:41 +0100 (CET) Date: Wed, 17 Feb 2021 11:01:41 +0100 From: Corinna Vinschen To: iNvEr7 Cc: "newlib@sourceware.org" , Richard Earnshaw Subject: Re: [PATCH] Semihosting ctr0 typo (adr/ldr)? Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: iNvEr7 , "newlib@sourceware.org" , Richard Earnshaw References: <2SG25aQ-_EdUvM9w1kXfGjpV_I6OSbvGLA9jIuXTs51Rzc7ESf1s9rIDWF85eATSD7jtZle5D2asRAeEEwtJs5adLfOf_c-uOa3myGWT-Ys=@protonmail.com> MIME-Version: 1.0 In-Reply-To: <2SG25aQ-_EdUvM9w1kXfGjpV_I6OSbvGLA9jIuXTs51Rzc7ESf1s9rIDWF85eATSD7jtZle5D2asRAeEEwtJs5adLfOf_c-uOa3myGWT-Ys=@protonmail.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-13.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Feb 2021 10:01:50 -0000 On Feb 16 22:56, iNvEr7 via Newlib wrote: > > --- > libgloss/arm/crt0.S | 2 +- > newlib/libc/sys/arm/crt0.S | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libgloss/arm/crt0.S b/libgloss/arm/crt0.S > index 8490bde2f..b8bbcee18 100644 > --- a/libgloss/arm/crt0.S > +++ b/libgloss/arm/crt0.S > @@ -283,7 +283,7 @@ > #ifdef ARM_RDI_MONITOR > /* Issue Angel SWI to read stack info. */ > movs r0, #AngelSWI_Reason_HeapInfo > - adr r1, .LC0 /* Point at ptr to 4 words to receive data. */ > + ldr r1, .LC0 /* Point at ptr to 4 words to receive data. */ > #ifdef THUMB_VXM > bkpt AngelSWI > #elif defined(__thumb2__) > diff --git a/newlib/libc/sys/arm/crt0.S b/newlib/libc/sys/arm/crt0.S > index 5e677a23c..3c5771229 100644 > --- a/newlib/libc/sys/arm/crt0.S > +++ b/newlib/libc/sys/arm/crt0.S > @@ -270,7 +270,7 @@ > #ifdef ARM_RDI_MONITOR > /* Issue Angel SWI to read stack info. */ > movs r0, #AngelSWI_Reason_HeapInfo > - adr r1, .LC0 /* Point at ptr to 4 words to receive data. */ > + ldr r1, .LC0 /* Point at ptr to 4 words to receive data. */ > #ifdef THUMB_VXM > bkpt AngelSWI > #elif defined(__thumb2__) > -- > 2.29.2 I'm a bit suprised that this problem hasn't been noticed for the last 10 years. I'm not familiar with the ARM stuff at all, so maybe somebody from ARM can chime in here? Thanks, Corinna