From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id 1428A385AC12 for ; Mon, 8 Mar 2021 10:00:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 1428A385AC12 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-392-fNvWv0AQNYOk-kRqIPcZOA-1; Mon, 08 Mar 2021 05:00:00 -0500 X-MC-Unique: fNvWv0AQNYOk-kRqIPcZOA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B97288143FF; Mon, 8 Mar 2021 09:59:59 +0000 (UTC) Received: from calimero.vinschen.de (unknown [10.40.195.180]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 82D1A5B4A9; Mon, 8 Mar 2021 09:59:59 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id C2D03A8266C; Mon, 8 Mar 2021 10:59:57 +0100 (CET) Date: Mon, 8 Mar 2021 10:59:57 +0100 From: Corinna Vinschen To: David Macek Cc: newlib@sourceware.org Subject: Re: [PATCH] libc: Replace i386/sys/fenv.h symlink with an #include shim Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: David Macek , newlib@sourceware.org References: MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Mar 2021 10:00:05 -0000 On Mar 7 16:03, David Macek via Newlib wrote: > As in fbaa096772f77be664864d80508906ad018cc23b: > > Having symlinks leads to issue unpacking the sources on platforms without proper > symlink support. These platforms mostly extract symlinks from the archive file > as copies of the files the symlinks point to. If the links appear in the tar > file before the source exists, it cannot copy the file. > > The solution in this patch is to convert the files that are symbolic > links into simple files which include the file they were linked to. > This should be more portable and avoids the symbolic link problem. > > Signed-off-by: David Macek > --- > > Excuse my ignorance, but is this acceptable? I'm not sure > what actually happens with these files, but it'd be nice to > get rid of the last symlink in the repo. This doesn't work. The machine-specific header will get installed to $DESTDIR/usr/include/sys/fenv.h, and it will now include a non-existing file. We have to keep the symlink or to duplicate the file. However, I'm not aware that we still support a development platform not supporting symlinks. Even WIndows supports them for ages now. Corinna