From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id AAA75388A430 for ; Thu, 11 Mar 2021 14:11:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org AAA75388A430 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-427-xBVsBGutN4u-S0vzYJfvwQ-1; Thu, 11 Mar 2021 09:11:55 -0500 X-MC-Unique: xBVsBGutN4u-S0vzYJfvwQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4D450800D55 for ; Thu, 11 Mar 2021 14:11:54 +0000 (UTC) Received: from calimero.vinschen.de (unknown [10.40.195.180]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 178935D9F2 for ; Thu, 11 Mar 2021 14:11:54 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id 677CBA82677; Thu, 11 Mar 2021 15:11:51 +0100 (CET) Date: Thu, 11 Mar 2021 15:11:51 +0100 From: Corinna Vinschen To: newlib@sourceware.org Subject: Re: [PATCH] libc: Replace i386/sys/fenv.h symlink with an #include shim Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org References: MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Mar 2021 14:11:59 -0000 On Mar 11 08:13, David Macek via Newlib wrote: > > > > This doesn't work. The machine-specific header will get installed to > > > > $DESTDIR/usr/include/sys/fenv.h, and it will now include a non-existing > > > > file. We have to keep the symlink or to duplicate the file. > > > > > > How come the newlib/libm/machine/i386/fenv.c non-symlink works? Is it > > > installed differently? > > > > It's not installed at all. It's a source file so the include only has > > to work at build time. The header file on the other hand will be > > installed on the target. As such, the result has to work on the target. > > Ah, right. But then I'm confused how a symlink can work in the first > place. I guess some part of the build process copies the contents > instead of the file. > > More to the point, how big of an issue would be to duplicate the file? I'm not hot on duplicating an identical file, it just raises maintenance cost. I'm currently looking into a solution to share the file without duplicating it. > > > Coincidentally, is newlib/libc/machine/ft32/stpcmp.S file correct? > > > > I have no idea, you have to ask the guys knowing that chip type. > > I didn't read the instructions, it's just the label looks wrong. :) Oh, right, I see what you mean. > Should I start another thread? Yes, ideally addressing the FT32 CPU in the subject. Thanks, Corinna