From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id C46F6385701F for ; Wed, 24 Mar 2021 10:16:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C46F6385701F Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-391-S7CeKVAAN4SquuMp36t44A-1; Wed, 24 Mar 2021 06:16:02 -0400 X-MC-Unique: S7CeKVAAN4SquuMp36t44A-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8CFAD801817 for ; Wed, 24 Mar 2021 10:16:00 +0000 (UTC) Received: from calimero.vinschen.de (unknown [10.40.195.60]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 568FE5447C for ; Wed, 24 Mar 2021 10:16:00 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id 9070AA80D4B; Wed, 24 Mar 2021 11:15:58 +0100 (CET) Date: Wed, 24 Mar 2021 11:15:58 +0100 From: Corinna Vinschen To: newlib@sourceware.org Subject: Re: [PATCH] libc: Replace i386/sys/fenv.h symlink with an #include shim Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org References: MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Mar 2021 10:16:06 -0000 On Mar 23 15:38, Corinna Vinschen via Newlib wrote: > On Mar 13 19:11, David Macek via Newlib wrote: > > > > More to the point, how big of an issue would be to duplicate the file? > > > > > > I'm not hot on duplicating an identical file, it just raises maintenance > > > cost. I'm currently looking into a solution to share the file without > > > duplicating it. > > > > Something like a Makefile rule? > > A bit more complicated in fact. I added a new topic branch called > topic/shared_arch_headers to the upstream repo, containing a single > patch > > a8cd2849ed0c Add build mechanism to share common header files between > machines Update: I split this patch into seven patches and force pushed them onto topic/shared_arch_headers: 3835c015d09d Add build mechanism to share common header files between machines e8e95bf6436a configure.host: define shared ix86 and x86_64 directory 718f3955449f fenv: add missing declarations to x86 fenv.h a0d06f6c50ed fenv: Move shared x86 sys/fenv.h from x86_64 to shared_x86 c06e30d3d961 fenv: move shared x86 fenv.c to libm/machine/shared_x86 7803e212adcd fenv: drop Cygwin-specific implementation in favor of newlib code 3b79d7e1c31f Cygwin: don't call _feinitialise from _dll_crt0 Please fetch this change and reset your branch to this new state. This should very much simplify reviewing the changes. > This patch introduces a new way to share header files between > architectures, not share by other architectures. > > I tried to change this in a generic way. The fenv stuff in this patch > is basically just the first user of this new mechanism. > > As a side-effect, this also allows to remove Cygwin's own fenv code > finally, which was already pretty much the same as newlib's x86 code > anyway. The major exception was the call to _feinitialise in Cygwin DLL > startup. Given that the newlib fenv code is auto-initializing, this can > go away. Cygwin just has to keep the _feinitialise entry point for > backward compatibility for apps built in a certain time frame. > > David, Joel, anybody else interested in this stuff, please inspect > this patch on the topic/shared_arch_headers branch thorougly. I will > not push this quickly, since we're in the process of releasing Cygwin > 3.2.0. I don't want to destabilise the release without need :) Thanks, Corinna