From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 4C3373853C0C for ; Wed, 28 Jul 2021 08:44:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4C3373853C0C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1627461892; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=BQlO2qhtX9g5YHthgARq3LbDRmYYf9t2+nqJDatSOAk=; b=dWyein9+fsRd1XgWXC/KWYK5srjfClHvbWYRjxQ16oko9t1EUcwilp0zPyfwPenK/BvXWQ r6HxjfbmemLmAjIETBs/nxWlha26uOaTqbWwKW4tKRQw2pDjlKb6PhizC0fAz75B/lI3Rk zMHVkgbZTDsru0Suur3CnUG5WIOFQLU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-243-jEJiK9krPk-ZOV4qrrH7ZA-1; Wed, 28 Jul 2021 04:44:51 -0400 X-MC-Unique: jEJiK9krPk-ZOV4qrrH7ZA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A6E25802937 for ; Wed, 28 Jul 2021 08:44:50 +0000 (UTC) Received: from calimero.vinschen.de (ovpn-112-26.ams2.redhat.com [10.36.112.26]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 79C811B400 for ; Wed, 28 Jul 2021 08:44:50 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id 147E6A80DD9; Wed, 28 Jul 2021 10:44:49 +0200 (CEST) Date: Wed, 28 Jul 2021 10:44:49 +0200 From: Corinna Vinschen To: newlib@sourceware.org Subject: Re: [PATCH 1/1] libc: Added implementations and prototypes for Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org References: <20210717101038.3283-1-mfjoyce2004@gmail.com> <20210717101038.3283-2-mfjoyce2004@gmail.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=vinschen@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Jul 2021 08:44:54 -0000 On Jul 23 07:44, Matthew Joyce wrote: > Hi Corinna, > > Thanks again for the explanation! I think I had just failed to include stdint.h. > > Now that it's working, I'd like to clarify: If SIG2STR_MAX is now 17, > this will impact the message "Unknown signal " in case the > signum isn't a valid, recognized signal number. > > Is it better to change the error message (by taking out the > part) or make SIG2STR_MAX larger? Actually, don't write anything into the string in case the signal doesn't exist. If the signal is not valid, sig2str is supposed to returns -1. It's not supposed to write anything into the buffer in that case. Corinna