From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 9CF23398D062 for ; Wed, 28 Jul 2021 09:33:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9CF23398D062 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1627464802; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=9tap2Mg2V4bUBfjrUMgCNsT4NQ0MpuvXs9ALqJAbmyI=; b=XlAjhxuZZsSTQwpk4zmMZOSua/AWWJtyz/oqOcyizv6ZXZAfUOcP8bX+6IKs7wN4dFcixk ZkZVo6EHfHpT5+wysb7+jhu9nVV3u3hwG+XOBV0HD719A11XFUNYu7o1bNVJ4hpSqaq/pS PAiEKYyiQpbvVSKd/haJQVoSJawEBE8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-413-LtQEC3QQMkOxW1TmSHsn5w-1; Wed, 28 Jul 2021 05:33:20 -0400 X-MC-Unique: LtQEC3QQMkOxW1TmSHsn5w-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E8B7194DC7 for ; Wed, 28 Jul 2021 09:33:19 +0000 (UTC) Received: from calimero.vinschen.de (ovpn-112-26.ams2.redhat.com [10.36.112.26]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BB166104327D for ; Wed, 28 Jul 2021 09:33:19 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id 52377A80DD5; Wed, 28 Jul 2021 11:33:18 +0200 (CEST) Date: Wed, 28 Jul 2021 11:33:18 +0200 From: Corinna Vinschen To: newlib@sourceware.org Subject: Re: [PATCH] Remove unneccesary parenthesis around declarator Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org References: <20210722214142.4008-1-maxim.blinov@embecosm.com> MIME-Version: 1.0 In-Reply-To: <20210722214142.4008-1-maxim.blinov@embecosm.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=vinschen@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-13.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Jul 2021 09:33:23 -0000 On Jul 22 22:41, Maxim Blinov wrote: > riscv64-unknown-elf-g++-11.1.0 regression suite reports the following > failures for > > $ make check-gcc-c++ RUNTESTFLAGS='dg.exp=Wstringop-overflow-6.C' > > ``` > FAIL: g++.dg/warn/Wstringop-overflow-6.C -std=gnu++14 (test for excess errors) > FAIL: g++.dg/warn/Wstringop-overflow-6.C -std=gnu++17 (test for excess errors) > FAIL: g++.dg/warn/Wstringop-overflow-6.C -std=gnu++2a (test for excess errors) > UNSUPPORTED: g++.dg/warn/Wstringop-overflow-6.C -std=gnu++98 > ``` > > The "excess errors" being > > ``` > output is In file included from /home/maxim/prj/riscv-upstream/install/riscv64-unknown-elf/include/wchar.h:6, > from /home/maxim/prj/riscv-upstream/build/gcc-stage2/riscv64-unknown-elf/libstdc++-v3/include/cwchar:44, > from /home/maxim/prj/riscv-upstream/build/gcc-stage2/riscv64-unknown-elf/libstdc++-v3/include/bits/postypes.h:40, > from /home/maxim/prj/riscv-upstream/build/gcc-stage2/riscv64-unknown-elf/libstdc++-v3/include/iosfwd:40, > from /home/maxim/prj/riscv-upstream/build/gcc-stage2/riscv64-unknown-elf/libstdc++-v3/include/ios:38, > from /home/maxim/prj/riscv-upstream/build/gcc-stage2/riscv64-unknown-elf/libstdc++-v3/include/ostream:38, > from /home/maxim/prj/riscv-upstream/build/gcc-stage2/riscv64-unknown-elf/libstdc++-v3/include/iostream:39, > from /home/maxim/prj/riscv-upstream/gcc-11.1.0/gcc/testsuite/g++.dg/warn/Wstringop-overflow-6.C:6: > /home/maxim/prj/riscv-upstream/install/riscv64-unknown-elf/include/sys/reent.h:685:11: warning: unnecessary parentheses in declaration of '_sig_func' [-Wparentheses] > ``` > --- > newlib/libc/include/sys/reent.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/newlib/libc/include/sys/reent.h b/newlib/libc/include/sys/reent.h > index 6e55e1c1f..34aff863a 100644 > --- a/newlib/libc/include/sys/reent.h > +++ b/newlib/libc/include/sys/reent.h > @@ -677,7 +677,7 @@ struct _reent > # endif > > /* signal info */ > - void (**(_sig_func))(int); > + void (**_sig_func)(int); > > /* These are here last so that __FILE can grow without changing the offsets > of the above members (on the off chance that future binary compatibility > -- > 2.17.1 Pushed. Thanks, Corinna