From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 8210B386197D for ; Wed, 28 Jul 2021 18:46:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8210B386197D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1627498000; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=wkMgw5y0ND9O2DJoSNy6QLzTxbKcex6/mE2P0t+Gg/U=; b=VKJ4W486OXDv2zvheN4hjUa/m48BqAaoaR6yDZZRhLvCcbFIP6/PR+IlqMFR/rAGTG/6e+ NXJx0ZSoulUmekJiSuur8yySxXzcXnllnjW4fK2iynw/oMn8y6wbhgqz6CTBZrUqD88gZ0 gZXNk76gfHHjGCATq7SGLJ14Iuyv2SA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-424-gSZRNzZLOmS8ul8qIzMv9A-1; Wed, 28 Jul 2021 14:46:37 -0400 X-MC-Unique: gSZRNzZLOmS8ul8qIzMv9A-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 36878801A92; Wed, 28 Jul 2021 18:46:36 +0000 (UTC) Received: from calimero.vinschen.de (ovpn-112-26.ams2.redhat.com [10.36.112.26]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D9D6B2635E; Wed, 28 Jul 2021 18:46:35 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id 72E34A80DED; Wed, 28 Jul 2021 20:46:34 +0200 (CEST) Date: Wed, 28 Jul 2021 20:46:34 +0200 From: Corinna Vinschen To: Brian Inglis Cc: newlib@sourceware.org Subject: Re: [PATCH 1/1] libc: Added implementations and prototypes for Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: Brian Inglis , newlib@sourceware.org References: <20210724083730.16959-1-mfjoyce2004@gmail.com> <20210724083730.16959-2-mfjoyce2004@gmail.com> <57f33efa-2450-ac5c-3ceb-be8beb183ca5@SystematicSw.ab.ca> MIME-Version: 1.0 In-Reply-To: <57f33efa-2450-ac5c-3ceb-be8beb183ca5@SystematicSw.ab.ca> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=vinschen@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Jul 2021 18:46:41 -0000 On Jul 28 09:25, Brian Inglis wrote: > On 2021-07-28 03:11, Corinna Vinschen wrote: > > Hi Matt, > > > > thanks for this v2. > > > > On Jul 24 10:37, Matt Joyce wrote: > > > Added implementations for sig2str() and str2sig() in libc/signal in order > > > to improve POSIX compliance. Added function prototypes to sys/signal.h. > > > Added Makefile.am entries to build the new file. > > > --- > > > [...] > > > +#if __GNU_VISIBLE > > > > I think this needs discussion. The sig2str/str2sig API has not been > > provided yet by GLibC. Using __GNU_VISIBLE in this context looks wrong. > > What we need, in fact, is a __POSIX_VISIBLE guard, but here's the > > problem: As far as I can see, the Issue 8 draft does not yet define a > > version number. > > > > If anybody has better information or a good idea how to guard this new > > API in the meantime, I'm all ears. > > Current values are: > > __POSIX_VISIBLE 199009 > __POSIX_VISIBLE 199209 > __POSIX_VISIBLE 199309 > __POSIX_VISIBLE 199506 > __POSIX_VISIBLE 200112 > __POSIX_VISIBLE 200809 > __POSIX_VISIBLE 201402 > > and anticipated release date is 2022 from FAQ > > https://www.opengroup.org/austin/faq.html > > Q8. Where is the schedule for draft development? > > so could use: > > __POSIX_VISIBLE >= 202202 /* FIXME when POSIX Issue 8 released */ Did you mean 202201? Sounds like a good idea in theory. But consider a project actually using this value and then the POSIX release defines the value 202207 or so. The project might stop to compile correctly. Along these lines, using 202212 for the interim might be the better approach. Then again, what if the release occurs in 2023 only? Still pretty unsure, Corinna