From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id CD9173888C65 for ; Mon, 2 Aug 2021 14:47:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CD9173888C65 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1627915664; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=cbGRERHjKtJL0VxQsrMkAmaJKNqpsT0xAnqYqS/NT4g=; b=BQpc5L3IvGd/0pRcWSgWUUS/wveLIZ9PY+lF4wV/SriWT9RWjPgCgV6leJY34pQl1Brgsb JNWu+bW0nwJ88E3/MnsNC4fDlfHLIlPDHtuCabJvujqQ4KGwrttSxUkwD6FQOc6L7t9PM/ iQlVBJm9BARa9U1gTFA27AV+336Z3N0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-326-9pDUuq51M9yXt-_0t6OJJg-1; Mon, 02 Aug 2021 10:47:42 -0400 X-MC-Unique: 9pDUuq51M9yXt-_0t6OJJg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DC1D5107ACF5; Mon, 2 Aug 2021 14:47:41 +0000 (UTC) Received: from calimero.vinschen.de (ovpn-112-6.ams2.redhat.com [10.36.112.6]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A55AB5DD68; Mon, 2 Aug 2021 14:47:41 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id 29287A80CFE; Mon, 2 Aug 2021 16:47:40 +0200 (CEST) Date: Mon, 2 Aug 2021 16:47:40 +0200 From: Corinna Vinschen To: Christoph Muellner Cc: newlib@sourceware.org, Kito Cheng Subject: Re: [PATCH] libc: Fix compilation for new sig2str/str2sig implementation Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: Christoph Muellner , newlib@sourceware.org, Kito Cheng References: <20210802140058.3885657-1-cmuellner@gcc.gnu.org> MIME-Version: 1.0 In-Reply-To: <20210802140058.3885657-1-cmuellner@gcc.gnu.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=vinschen@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Aug 2021 14:47:51 -0000 On Aug 2 16:00, Christoph Muellner wrote: > A recent patch introduced new code for sig2str/str2sig. > This code does not properly exclude code that requires > SIGRTMIN/SIGRTMAX to be defined and triggers the following > compile error: > > newlib/libc/signal/sig2str.c:199:8: error: 'SIGRTMIN' undeclared > newlib/libc/signal/sig2str.c:200:29: error: 'SIGRTMAX' undeclared > > Let's add the missing guards. > > Fixes: 2b50ec0cd205 ("libc: Fix compilation for new sig2str/str2sig implementation") > > Signed-off-by: Christoph Muellner > --- > newlib/libc/signal/sig2str.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) Pushed. Thanks, Corinna