From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 1159B385780F for ; Tue, 3 Aug 2021 07:44:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1159B385780F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1627976680; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=suIK/f2A7YlOGqgrmlLHWlkEP9ZNxv6oF/uFvDJND+c=; b=hcmtwVfURZeh7x9lvjQTzD/AKm864NZkwb0m+4xsConfp6eFQFqCMLkhVY11grDcxYrDh9 nfzx24pG5MT7F9pTXAQUVt3tj45Pscq1mTXCV4IXTDMAp53dikeSJj3PhbyP7fDTU7P8Zk HwJruVXdym4KpSWYH8jiVdcGXCxLD7U= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-58-BTrM5j_gMmi52Zpz6fby6w-1; Tue, 03 Aug 2021 03:44:39 -0400 X-MC-Unique: BTrM5j_gMmi52Zpz6fby6w-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6F16A1084F53; Tue, 3 Aug 2021 07:44:38 +0000 (UTC) Received: from calimero.vinschen.de (ovpn-112-6.ams2.redhat.com [10.36.112.6]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4095E4A66; Tue, 3 Aug 2021 07:44:38 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id C82B3A80D90; Tue, 3 Aug 2021 09:44:36 +0200 (CEST) Date: Tue, 3 Aug 2021 09:44:36 +0200 From: Corinna Vinschen To: Matt Joyce Cc: newlib@sourceware.org Subject: Re: [PATCH 1/1] libc: Added implementation for sig2str/str2sig. Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: Matt Joyce , newlib@sourceware.org References: <20210803035436.819811-1-mfjoyce2004@gmail.com> <20210803035436.819811-2-mfjoyce2004@gmail.com> MIME-Version: 1.0 In-Reply-To: <20210803035436.819811-2-mfjoyce2004@gmail.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=vinschen@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Aug 2021 07:44:42 -0000 Hi Matt, On Aug 3 05:54, Matt Joyce wrote: > Added implementations for sig2str() and str2sig() in libc/signal > in order to improve POSIX compliance. Added fucntion prototypes > in libc/include/sys/signal.h. This isn't quite right. I already pushed your patch with the fixes I applied, as well as the patch from Christoph Muellner. If you want to apply further patches, you have to send them as additional patch on top of the current state of the repo. Thanks, Corinna