Re: [PATCH] libgloss/newlib: rename configure.in to configure.ac

[Mike Frysinger <vapier@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 2757 bytes --]

On 14 Sep 2021 00:54, Hans-Bernhard Bröker wrote:
> Am 13.09.2021 um 16:13 schrieb Mike Frysinger:
>  > On 13 Sep 2021 12:12, Corinna Vinschen wrote:
>  >> On Sep  9 17:06, Mike Frysinger wrote:
>  >>> The .in name has been deprecated for a long time in favor of .ac.
> 
>  >> ACK.  Are you going to regen afterwards?
> 
>  > that should be a nop as the filename input shouldn't affect the output.
>  > i confirmed on one or two dirs.
> 
> The name of configure.{in|ac} is supposed to show up in just about every 
> Makefile.in.  The maintainer rules to update configure rely on that. 
> Automake-generated Makefile.in pick up this change automatically.

thanks for pointing this out.  i sent a patch for it.

> libgloss doesn't use automake, so there you would have to do all this by 
> hand.  Or keep on not doing it at all: at the moment there are no such 
> maintainer-specific rules in the libgloss Makefile.in except in 
> libgloss/wince, which does use automake.

the wince dir is running ancient automake-1.4 still.  the rest of newlib
is at least up on automake-1.11, but even that should get moved to 1.15
like the rest of the projects.  but that's prob another yak shave i'm not
in the mood to tackle.

>  > i agree that we should add
>  > a macro to enforce a specific autoconf version and regen everything with
>  > that :).
> 
> No need to add one ;-).  That's precisely what config/override.m4 
> already does.
> 
> The entire newlib tree relies quite heavily on features that have been 
> dropped from autoconf a _long_ time ago. The version it requires is 2.64 
> from the year 2008.  Getting all that resolved takes quite a bit more 
> effort than just renaming files and dropping the explicit restriction. 
> Every single Makefile.am and configure.ac has to be modified to remove 
> things like the cygnus mode option to automake, or the outdated use of 
> INCLUDES instead of AM_CPPFLAGS.

there are large variety of autoconf versions in use in the tree :(.
$ find newlib/ libgloss/ -name configure -exec sed -n '/Generated by GNU Autoconf/p' {} + | sort | uniq -c
      1 # Generated by GNU Autoconf 2.59.
     26 # Generated by GNU Autoconf 2.61.
      6 # Generated by GNU Autoconf 2.63.
      2 # Generated by GNU Autoconf 2.64.
      2 # Generated by GNU Autoconf 2.66.
     11 # Generated by GNU Autoconf 2.68.
      1 # Generated by GNU Autoconf 2.68 for libepiphany 0.0.1.
      1 # Generated by GNU Autoconf 2.68 for libgloss LIBGLOSS_VERSION.
      1 # Generated by GNU Autoconf 2.68 for libor1k 0.0.1.
      2 # Generated by GNU Autoconf 2.68 for newlib 2.5.0.
    112 # Generated by GNU Autoconf 2.68 for newlib 4.1.0.
      3 # Generated by GNU Autoconf 2.69.
-mike

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]