From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 31A9E3857C75 for ; Tue, 14 Sep 2021 08:39:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 31A9E3857C75 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631608749; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WpZrhxqu68vQSU800mtx5ryswl579+fkurbkDhn1Xz4=; b=U0ilqL4Xb5bI6Y66D2IqjHEuI+IP9vA4SJQ3/emBCGvXPFKvueXY+Iq+K4HKiYfQ2maRLZ waJTZo2vvDz+tIey+wnzDbrKRf3qUQWdGJo15REY0W+iG0IL3+Wkf8VLr/wqUPk6O1L85s SHt8FqG28fgqhRNVbDxvUChmJQysAoM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-397-8NQ4lJguNjmWwaa9cgF9yw-1; Tue, 14 Sep 2021 04:38:56 -0400 X-MC-Unique: 8NQ4lJguNjmWwaa9cgF9yw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4EDC610B744C for ; Tue, 14 Sep 2021 08:38:55 +0000 (UTC) Received: from calimero.vinschen.de (ovpn-112-2.ams2.redhat.com [10.36.112.2]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 105525D6A8 for ; Tue, 14 Sep 2021 08:38:55 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id 9B27BA8053B; Tue, 14 Sep 2021 10:38:53 +0200 (CEST) Date: Tue, 14 Sep 2021 10:38:53 +0200 From: Corinna Vinschen To: newlib@sourceware.org Subject: Re: [PATCH] libgloss/newlib: rename configure.in to configure.ac Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org References: <20210909210636.15739-1-vapier@gentoo.org> <904839f2-3aa7-b659-2dae-c942c6c67599@t-online.de> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=vinschen@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Sep 2021 08:39:13 -0000 On Sep 13 23:03, Mike Frysinger wrote: > On 14 Sep 2021 00:54, Hans-Bernhard Bröker wrote: > > Am 13.09.2021 um 16:13 schrieb Mike Frysinger: > > > On 13 Sep 2021 12:12, Corinna Vinschen wrote: > > >> On Sep 9 17:06, Mike Frysinger wrote: > > >>> The .in name has been deprecated for a long time in favor of .ac. > > > > >> ACK. Are you going to regen afterwards? > > > > > that should be a nop as the filename input shouldn't affect the output. > > > i confirmed on one or two dirs. > > > > The name of configure.{in|ac} is supposed to show up in just about every > > Makefile.in. The maintainer rules to update configure rely on that. > > Automake-generated Makefile.in pick up this change automatically. > > thanks for pointing this out. i sent a patch for it. > > > libgloss doesn't use automake, so there you would have to do all this by > > hand. Or keep on not doing it at all: at the moment there are no such > > maintainer-specific rules in the libgloss Makefile.in except in > > libgloss/wince, which does use automake. > > the wince dir is running ancient automake-1.4 still. the rest of newlib > is at least up on automake-1.11, but even that should get moved to 1.15 > like the rest of the projects. but that's prob another yak shave i'm not > in the mood to tackle. > > > > i agree that we should add > > > a macro to enforce a specific autoconf version and regen everything with > > > that :). > > > > No need to add one ;-). That's precisely what config/override.m4 > > already does. > > > > The entire newlib tree relies quite heavily on features that have been > > dropped from autoconf a _long_ time ago. The version it requires is 2.64 > > from the year 2008. Getting all that resolved takes quite a bit more > > effort than just renaming files and dropping the explicit restriction. > > Every single Makefile.am and configure.ac has to be modified to remove > > things like the cygnus mode option to automake, or the outdated use of > > INCLUDES instead of AM_CPPFLAGS. > > there are large variety of autoconf versions in use in the tree :(. > $ find newlib/ libgloss/ -name configure -exec sed -n '/Generated by GNU Autoconf/p' {} + | sort | uniq -c > 1 # Generated by GNU Autoconf 2.59. > 26 # Generated by GNU Autoconf 2.61. > 6 # Generated by GNU Autoconf 2.63. > 2 # Generated by GNU Autoconf 2.64. > 2 # Generated by GNU Autoconf 2.66. > 11 # Generated by GNU Autoconf 2.68. > 1 # Generated by GNU Autoconf 2.68 for libepiphany 0.0.1. > 1 # Generated by GNU Autoconf 2.68 for libgloss LIBGLOSS_VERSION. > 1 # Generated by GNU Autoconf 2.68 for libor1k 0.0.1. > 2 # Generated by GNU Autoconf 2.68 for newlib 2.5.0. > 112 # Generated by GNU Autoconf 2.68 for newlib 4.1.0. > 3 # Generated by GNU Autoconf 2.69. > -mike The versions Jeff and I use for newlib are aclocal-1.11.6 -I. -I.. -I ../.. -I ../../.. autoconf-2.68 automake-1.11.6 --cygnus --no-force The problem is to revamp the newlib tree to do the right thing without the dreaded --cygnus option. In the meantime we are using the latest automake/autoconf tools at least in the Cygwin part of the repo, thanks to Jon Turney. Corinna