From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTPS id A95383858C27 for ; Wed, 27 Oct 2021 18:07:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A95383858C27 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635358029; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=DTMz7eiLm+nVaGA9RjW+bqVanXhCDhpQ3L2F37dJLEE=; b=AoA8cqTxlDFrc+E0RmZDBzW27GwLvdDBxEmLr292eAGeUVMHATPWY2jqoya4OrTfiWLlKl ejJoKv/9qAdQwVAjlqG/OxZcZMOQFQfjajJ14lJHo9iT3rhRBH6A0Eqz5Ayca51xx0Y6V3 aLin+wVZdqMBHGqLczA2q03vNwhfFRo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-583-PR0q3N9cPnuGoXdyZTAsFA-1; Wed, 27 Oct 2021 14:07:06 -0400 X-MC-Unique: PR0q3N9cPnuGoXdyZTAsFA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 16A4218D6A25; Wed, 27 Oct 2021 18:07:05 +0000 (UTC) Received: from calimero.vinschen.de (ovpn-112-10.ams2.redhat.com [10.36.112.10]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DBD7A5DA61; Wed, 27 Oct 2021 18:07:04 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id 698D8A80BC1; Wed, 27 Oct 2021 20:07:03 +0200 (CEST) Date: Wed, 27 Oct 2021 20:07:03 +0200 From: Corinna Vinschen To: newlib@sourceware.org Cc: Christian Biesinger Subject: Re: [PATCH v2] Unconditionally declare strsignal Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org, Christian Biesinger References: <20211027164122.2268783-1-cbiesinger@google.com> MIME-Version: 1.0 In-Reply-To: <20211027164122.2268783-1-cbiesinger@google.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=vinschen@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-12.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Oct 2021 18:07:11 -0000 On Oct 27 12:41, Christian Biesinger via Newlib wrote: > Currently, newlib does not declare strsignal if DEFS_H is defined, > ostensibly to work around a gdb bug. However, gdb itself compiles > even with this ifndef removed, and this makes sim (another part of > gdb) fail to compile. > > Since it is not clear exactly what issue this was working around, > this patch just replaces that ifdef with the correct check, > i.e. __POSIX_VISIBLE >= 200809. > --- > newlib/libc/include/string.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/newlib/libc/include/string.h b/newlib/libc/include/string.h > index 60e837bc0..32199c027 100644 > --- a/newlib/libc/include/string.h > +++ b/newlib/libc/include/string.h > @@ -130,7 +130,7 @@ char *strlwr (char *); > char *strupr (char *); > #endif > > -#ifndef DEFS_H /* Kludge to work around problem compiling in gdb */ > +#if __POSIX_VISIBLE >= 200809 > char *strsignal (int __signo); > #endif > > -- > 2.33.0.1079.g6e70778dc9-goog Pushed. Thanks, Corinna