From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 56EDF3858409 for ; Fri, 12 Nov 2021 10:27:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 56EDF3858409 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1636712876; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=2p9Z0+Kwti5R90PcxtDq1ARkh87MQ3Ltby8TWAfDb0s=; b=dLMi+dvAYo2e3+8BA0vKG3l9l1L4It5rsHSRTIsUb8ymnlnQ4kf3PbjJU100pcuBWUuWOX +iRGGRsjfv3bWuQ9vf3Y6uMq1VCzhF476p2BYjulz9dnjkWPod6BL76KAYmjzY63Rnl5jn 4ZwBIoqweNCTujMwN0AD9q2GQFN+5Fc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-367-pQCmZJZUMgOqLsS2X4Y8SQ-1; Fri, 12 Nov 2021 05:27:55 -0500 X-MC-Unique: pQCmZJZUMgOqLsS2X4Y8SQ-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 582B6E769 for ; Fri, 12 Nov 2021 10:27:54 +0000 (UTC) Received: from calimero.vinschen.de (ovpn-112-10.ams2.redhat.com [10.36.112.10]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1F89E604CC for ; Fri, 12 Nov 2021 10:27:54 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id 726F0A80D4C; Fri, 12 Nov 2021 11:27:52 +0100 (CET) Date: Fri, 12 Nov 2021 11:27:52 +0100 From: Corinna Vinschen To: newlib@sourceware.org Subject: Re: [PATCH v2] ctype: use less short names in public header Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org References: <20211109012459.30826-1-vapier@gentoo.org> <20211111013700.9873-1-vapier@gentoo.org> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=vinschen@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Nov 2021 10:27:59 -0000 On Nov 11 17:28, Mike Frysinger wrote: > On 11 Nov 2021 11:35, Corinna Vinschen wrote: > > On Nov 10 20:37, Mike Frysinger wrote: > > > We're seeing a build failure in GNU sim code which is using _P locally > > > but the ctype.h define clashes with it. Rename these to use the same > > > symbols that glibc does. They're a bit more verbose, but seems likely > > > that we'll have fewer conflicts if glibc isn't seeing them. > > > > > > However, these shortnames are still used internally by ctype modules > > > to produce pretty concise source code, so move the short names to the > > > internal ctype_.h where short name conflicts shouldn't show up. > > > --- > > > newlib/libc/ctype/ctype_.h | 10 +++++ > > > newlib/libc/ctype/isalnum.c | 2 +- > > > newlib/libc/ctype/isalnum_l.c | 2 +- > > > newlib/libc/ctype/isalpha.c | 2 +- > > > newlib/libc/ctype/isalpha_l.c | 2 +- > > > newlib/libc/ctype/isblank.c | 2 +- > > > newlib/libc/ctype/isblank_l.c | 2 +- > > > newlib/libc/ctype/iscntrl.c | 2 +- > > > newlib/libc/ctype/iscntrl_l.c | 2 +- > > > newlib/libc/ctype/isdigit.c | 2 +- > > > newlib/libc/ctype/isdigit_l.c | 2 +- > > > newlib/libc/ctype/islower.c | 2 +- > > > newlib/libc/ctype/islower_l.c | 2 +- > > > newlib/libc/ctype/isprint.c | 4 +- > > > newlib/libc/ctype/isprint_l.c | 4 +- > > > newlib/libc/ctype/ispunct.c | 2 +- > > > newlib/libc/ctype/ispunct_l.c | 2 +- > > > newlib/libc/ctype/isspace.c | 2 +- > > > newlib/libc/ctype/isspace_l.c | 2 +- > > > newlib/libc/ctype/isupper.c | 2 +- > > > newlib/libc/ctype/isupper_l.c | 2 +- > > > newlib/libc/ctype/isxdigit.c | 2 +- > > > newlib/libc/ctype/isxdigit_l.c | 2 +- > > > newlib/libc/include/ctype.h | 67 ++++++++++++++++++---------------- > > > 24 files changed, 69 insertions(+), 56 deletions(-) > > > > Good idea to move the _X macros to ctype_.h :) Please push. > > i pushed this since it's standalone now. not sure if you're also saying > "define _COMPILING_NEWLIB for all targets when compiling" is OK, so i haven't > pushed that yet. Oh, that was implicitly clear to me, given the original dependency. So, yeah, please push. Thanks, Corinna