From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTPS id 1E5B33858D39 for ; Tue, 9 Nov 2021 11:44:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1E5B33858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1636458273; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=IPmjxml6k6Z9jSl2plEwiHKWGN1jIm/EODGUODDoqCg=; b=UZ9mjO3y3yjyiDYJRbHAIKDrhm8Tyw/zmN0eq1u15ORtVV/3/WAjn3N46k9D0N4QlvP4Im G52Rs4cjZEt46E7dARi99ByqjLzagNBe7rcu/uS1WUr78j5bJm5keKr8JpETZaa4nAI8B5 SsZr9eSG4UOS291sRAPErnSXxLzwo8c= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-407-OgQHFF0gOT-zph8jBY3ZPg-1; Tue, 09 Nov 2021 06:44:32 -0500 X-MC-Unique: OgQHFF0gOT-zph8jBY3ZPg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 89015100C663 for ; Tue, 9 Nov 2021 11:44:31 +0000 (UTC) Received: from calimero.vinschen.de (ovpn-112-10.ams2.redhat.com [10.36.112.10]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5AB4460843 for ; Tue, 9 Nov 2021 11:44:31 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id 0208EA80978; Tue, 9 Nov 2021 12:44:30 +0100 (CET) Date: Tue, 9 Nov 2021 12:44:29 +0100 From: Corinna Vinschen To: newlib@sourceware.org Subject: Re: [PATCH] newlib: mips: delete glibc-specific logic Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org References: <20211109032126.3250-1-vapier@gentoo.org> MIME-Version: 1.0 In-Reply-To: <20211109032126.3250-1-vapier@gentoo.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=vinschen@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Nov 2021 11:44:35 -0000 On Nov 8 22:21, Mike Frysinger wrote: > This code looks like it's written to be copied & pasted between diff > C libraries and relies on _LIBC only being used with glibc. This will > break when newlib changes from _COMPILING_NEWLIB to _LIBC, so delete > the glibc-specific logic ahead of time. > --- > newlib/libc/machine/mips/memcpy.S | 11 ----------- > newlib/libc/machine/mips/memset.S | 10 ---------- > newlib/libc/machine/mips/strcmp.S | 9 --------- > 3 files changed, 30 deletions(-) ACK, please push. There's a Cygwin patch required as well (winsup/cygwin/tzcode/private.h) before we can change to _LIBC. Do you want to do that or shall I? Thanks, Corinna