From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id 7A2553857C59 for ; Wed, 10 Nov 2021 00:18:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7A2553857C59 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org Received: by smtp.gentoo.org (Postfix, from userid 559) id 1F329342F8A; Wed, 10 Nov 2021 00:18:06 +0000 (UTC) Date: Tue, 9 Nov 2021 19:18:08 -0500 From: Mike Frysinger To: newlib@sourceware.org Subject: Re: [PATCH 2/2] ctype: use less short names in public header Message-ID: Mail-Followup-To: newlib@sourceware.org References: <20211109012447.30698-1-vapier@gentoo.org> <20211109012459.30826-1-vapier@gentoo.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="UQuoCNwzFu9au65b" Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Nov 2021 00:18:08 -0000 --UQuoCNwzFu9au65b Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 09 Nov 2021 12:38, Corinna Vinschen wrote: > On Nov 8 20:24, Mike Frysinger wrote: > > We're seeing a build failure in GNU sim code which is using _P locally > > but the ctype.h define clashes with it. Rename these to use the same > > symbols that glibc does. They're a bit more verbose, but seems likely > > that we'll have fewer conflicts if glibc isn't seeing them. > ^^^^^ > Mixing newlib and glibc? That's just a typo, I guess? i meant glibc here. these are the same symbol names that glibc is using, and it's not seeing conflicts in the wider ecosystem. so if they aren't seeing issues, it's likely newlib won't either if it uses the same names. > > However, these shortnames are still used internally by ctype modules > > to produce pretty concise source code, so use _COMPILING_NEWLIB to > > keep them around when compiling newlib itself where we have better > > control over short name conflicts. >=20 > Hmm. I'm not sure we should really maintain two different sets of > symbols. I think it would be better to go the entire way and replace > the single letter symbols with the new, more speaking ones throughout. > There are not that many affected files and the change might be done with > sed mostly. >=20 > The only exceptions *could* be libc/ctype/ctype_.c and the local > ctype_iso.h and ctype_cp.h headers it includes. A local definition > of the single letter symbols in ctype_.c would be sufficient then. > But even there we might be better off with the new symbols in the long > run... i don't have an opinion. i can easily run sed on the files and send the result out. i figured people would prefer having the condense tables so they could scan them quicker by eye. so let me know what you want and i'll do it ;). -mike --UQuoCNwzFu9au65b Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmGLD8AACgkQQWM7n+g3 9YFA6RAA5ALZ1c0U/E3v41m29C3bCPd/IbIExxpUIoezl7ARMPg/hpdIufW6x7Q/ acrmhltP79Ug/lLR6fe/nY/xOP7bIpeoYxvHyekEhALOEq2jabzNkXsJd8GzAAY5 cmldeJN3JGmsG/q/H2RzYd0WU8/Dw81x+v1XariiknRYbxRgobO7UM3OJ3s4cuL4 RdkqAqnYCHbQXDry6eSDjAICZfxjNpftwucCL/rEpAjyMH9kBWOP+QddgMX7xPu6 FNX13WBC44fWKtBkMO5tU1fUPk6m+zv2nV8rc/DxFOO4lWSFPxZIRpFHNIz1K6eD xKurYyqARbgtuQwI/8Wyu+UIdzywYmd2CqhuRAFMOWilMozllvyqteJPaW7vTMPJ bAb2F2b9cIlxAnmSKBECgPyObDQeGtk9VHVuCWASJDrLloqngRc0/Y8w2zGGc+JY 38EThiWK4rzIgHR7Ir6niKWBblSwvl9cUD5rodULWGY2xXy0OSecUGsXfxJSiCin bYRtKCmUkIEzJ0VAyfhuOMfaScF0zHayNyuiSfJkIBq3IAXoO+HlX2sjMeLiDwGJ qcI9VkLhLE8KH679+uAcKyBTEFnvy54tZf6Ynt9QxEg7OZLb5r8tn2Seyd7ie7+X e2oHJ7gbLlvZgoZS8xvGcdmQ8IPIcXEbmSJnHFICzPwvz702obg= =7Ztt -----END PGP SIGNATURE----- --UQuoCNwzFu9au65b--