From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (mail.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id BC8AE385842B for ; Wed, 10 Nov 2021 02:07:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BC8AE385842B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org Received: by smtp.gentoo.org (Postfix, from userid 559) id 08912342FAC; Wed, 10 Nov 2021 02:07:30 +0000 (UTC) Date: Tue, 9 Nov 2021 21:07:32 -0500 From: Mike Frysinger To: Keith Packard Cc: newlib@sourceware.org Subject: Re: [PATCH] newlib: undefine _FORTIFY_SOURCE Message-ID: Mail-Followup-To: Keith Packard , newlib@sourceware.org References: <20211109025656.26127-1-vapier@gentoo.org> <87tugmm33g.fsf@keithp.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="XlhChB3DU7kB/nTl" Content-Disposition: inline In-Reply-To: <87tugmm33g.fsf@keithp.com> X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Nov 2021 02:07:33 -0000 --XlhChB3DU7kB/nTl Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 08 Nov 2021 19:15, Keith Packard wrote: > Mike Frysinger writes: > > Since newlib isn't prepared to build itself with _FORTIFY_SOURCE, and > > it's not clear if it's even useful, disable it when building the code. >=20 > It is useful; I've caught a few library bugs when I turned this on for > picolibc. Fixing newlib to handle -D_FORTIFY_SOURCE could probably start > with the patches I did in picolibc, which mostly just #undef the various > mem and str functions before defining them. i'm not against making it work, but it doesn't now, so we should disable the logic if/until it's made to actually work. -mike --XlhChB3DU7kB/nTl Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmGLKWQACgkQQWM7n+g3 9YEyiA/9Ee/DWWxH9Iz4RUHtuzzIuYP6V8ITJsNlIwTgH3+eJTQCIfgcTGQIToat wg3QttUIO8SyEFYav0rKEO4fp4I9DL6c4U6rpLOFMPin4r7/VoatPjX+FjFhomBQ 7sZ+HIxcu5exy1KgECkB6TFSMe45nuUibRjIVqYLVHVb8RHLn+Y5H7O9IMAKKlB9 CR/bcAH0OasO9Xu2fa8O/VClDH9JvARdPuQRA/CNXCIwOLWwPGi0uYPnfgLmm2Yd 6f3jU2vvph5yLSGnWN31nay2hOLYaiAttTsvrMuMsFyg0QI/MbW/+h5zozrXruWD MR71e0YywVBrM8kWX4UwT0Zad/sL8ieYSKqFLS8at3H/lapklhQ/CYqcEhcLPjBf R7TrwROVo14UwViL/RCMG3QbCEEYUquGp70kgJYh6XrekIt+LAHlHNsQynCqYRXD CdpBbHvMfCgnBJlfh0sFoXlMOP3G1LOaFR/+8Xqhd4weT2MyrLL3hcmrXMH8cjm9 7ALXO7kYwRy+AaHJkT1LH+pG/SBa7pqKN7WmsEp5UAFlWnDy/f0dcQC4QlPRgQpG mvpTJvwX02sA5eFwkUZmUsiPYfHys8iLMf9Ymikc6cIpKgvcBf2FJJ08HxTB8fHa XCvOuublDlY47c+xJuDwfIJLCfjBW+uPtncwfmnRkVN8N84mP9Q= =d2CU -----END PGP SIGNATURE----- --XlhChB3DU7kB/nTl--