From: Corinna Vinschen <vinschen@redhat.com>
To: newlib@sourceware.org
Subject: Re: [PATCH 2/2] ctype: use less short names in public header
Date: Wed, 10 Nov 2021 11:56:36 +0100 [thread overview]
Message-ID: <YYulZM7UF+h7ch4T@calimero.vinschen.de> (raw)
In-Reply-To: <YYsPwCJzVRgjirMr@vapier>
On Nov 9 19:18, Mike Frysinger wrote:
> On 09 Nov 2021 12:38, Corinna Vinschen wrote:
> > On Nov 8 20:24, Mike Frysinger wrote:
> > > We're seeing a build failure in GNU sim code which is using _P locally
> > > but the ctype.h define clashes with it. Rename these to use the same
> > > symbols that glibc does. They're a bit more verbose, but seems likely
> > > that we'll have fewer conflicts if glibc isn't seeing them.
> > ^^^^^
> > Mixing newlib and glibc? That's just a typo, I guess?
>
> i meant glibc here. these are the same symbol names that glibc is using,
> and it's not seeing conflicts in the wider ecosystem. so if they aren't
> seeing issues, it's likely newlib won't either if it uses the same names.
>
> > > However, these shortnames are still used internally by ctype modules
> > > to produce pretty concise source code, so use _COMPILING_NEWLIB to
> > > keep them around when compiling newlib itself where we have better
> > > control over short name conflicts.
> >
> > Hmm. I'm not sure we should really maintain two different sets of
> > symbols. I think it would be better to go the entire way and replace
> > the single letter symbols with the new, more speaking ones throughout.
> > There are not that many affected files and the change might be done with
> > sed mostly.
> >
> > The only exceptions *could* be libc/ctype/ctype_.c and the local
> > ctype_iso.h and ctype_cp.h headers it includes. A local definition
> > of the single letter symbols in ctype_.c would be sufficient then.
> > But even there we might be better off with the new symbols in the long
> > run...
>
> i don't have an opinion. i can easily run sed on the files and send the
> result out. i figured people would prefer having the condense tables so
> they could scan them quicker by eye.
>
> so let me know what you want and i'll do it ;).
Great. Let's try the compromise from above: Drop _X etc from the
header, just define them in libc/ctype/ctype_.c.
Thanks,
Corinna
next prev parent reply other threads:[~2021-11-10 10:56 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-07 0:21 what's up with _COMPILING_NEWLIB Mike Frysinger
2021-11-08 10:05 ` Corinna Vinschen
2021-11-08 11:46 ` Mike Frysinger
2021-11-08 15:05 ` Corinna Vinschen
2021-11-08 18:14 ` Mike Frysinger
2021-11-09 1:24 ` [PATCH 1/2] define _COMPILING_NEWLIB for all targets when compiling Mike Frysinger
2021-11-09 1:24 ` [PATCH 2/2] ctype: use less short names in public header Mike Frysinger
2021-11-09 11:38 ` Corinna Vinschen
2021-11-10 0:18 ` Mike Frysinger
2021-11-10 10:56 ` Corinna Vinschen [this message]
2021-11-30 12:18 ` Jonathan Wakely
2021-11-11 1:37 ` [PATCH v2] " Mike Frysinger
2021-11-11 10:35 ` Corinna Vinschen
2021-11-11 22:28 ` Mike Frysinger
2021-11-12 10:27 ` Corinna Vinschen
2021-11-20 20:08 ` Brian Inglis
2021-11-23 15:09 ` [PATCH 2/2] " Richard Earnshaw
2021-11-24 4:15 ` Mike Frysinger
2021-11-24 10:58 ` Richard Earnshaw
2021-11-24 11:01 ` Richard Earnshaw
2021-11-30 12:01 ` Jonathan Wakely
2021-11-30 15:14 ` Corinna Vinschen
2021-11-30 17:12 ` Jonathan Wakely
2021-11-30 17:15 ` Jonathan Wakely
2021-11-30 17:52 ` Richard Earnshaw
2021-12-02 10:27 ` Corinna Vinschen
2021-12-03 9:56 ` Corinna Vinschen
2021-12-05 9:42 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYulZM7UF+h7ch4T@calimero.vinschen.de \
--to=vinschen@redhat.com \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).