From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 5A99A3858D39 for ; Mon, 15 Nov 2021 16:12:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5A99A3858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1636992731; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=7kgtpToCdBg7IHVe8vUcjcXlor8zLJL8GVl0WNuAWYY=; b=acgKI/KHFlNcDWWu9LWD3uPfyin9Mz1AYMjVjwQF+ifg0kGfjAJaJNcF3HWdMsalVZD4x/ 5XhU41XW7KlJxZS4TE6jZzuqyy5GVHha43I3CIRyp4KDPs2AX8qS4tMTdWZ6gWDBV+7lrC RyKjt9mw/CwC5EMHJpTVKJfh/qiS59M= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-546-oRSv_0qnM6-a5ejEVs1_lg-1; Mon, 15 Nov 2021 11:12:07 -0500 X-MC-Unique: oRSv_0qnM6-a5ejEVs1_lg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EC01A1015DA0 for ; Mon, 15 Nov 2021 16:12:05 +0000 (UTC) Received: from calimero.vinschen.de (ovpn-112-10.ams2.redhat.com [10.36.112.10]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B9CD722719 for ; Mon, 15 Nov 2021 16:12:05 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id 43737A80D6A; Mon, 15 Nov 2021 17:12:04 +0100 (CET) Date: Mon, 15 Nov 2021 17:12:04 +0100 From: Corinna Vinschen To: newlib@sourceware.org Subject: Re: [PATCH] update to Unicode 14.0 Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org References: <31f46170-d893-6b00-fa0e-e69d5913740b@towo.net> <673a19c1-1846-aa70-51b0-8ff1c68caecd@towo.net> MIME-Version: 1.0 In-Reply-To: <673a19c1-1846-aa70-51b0-8ff1c68caecd@towo.net> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=vinschen@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_NUMSUBJECT, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Nov 2021 16:12:12 -0000 On Nov 15 15:22, Thomas Wolff wrote: > > Am 15.11.2021 um 14:06 schrieb Corinna Vinschen: > > On Nov 11 21:32, Thomas Wolff wrote: > > > Unicode update patch attached. > > > Responses to previous comments: > > > > wouldn't it make sense to remove the temporary downloaded files like > > > > libc/ctype/UnicodeData.txt, etc? > > > > Either automatically after creating the generated files > > > Maybe. I didn't implement it, like in my other projects (mintty, mined), as > > > it causes redundant multiple downloads during development. > > > > or in a matching MAINTAINERCLEANFILES variable in Makefile.am? > > > I had looked into it but there isn't such a variable yet and I'm not > > > familiar with automake/conv stuff, so feel free to add if suitable. > > > > Also, maybe it makes sense to add these temporary files to the .gitignore file? > > > I'm not in favour of the .gitignore idea as its only purpose seems to be to > > > smooth out effects of `git add *`-like check-ins, which I think shouldn't be > > > done anyway; I feel the concept encourages sloppy repository management. > > > But again, this isn't my project so feel free to adjust the build. > > It's not my project either, it's a collaborative effort. So you don't have any other idea to fix this issue? > To be honest, I don't really understand the issue. So the files stay hanging > around for someone who builds the update. What's the problem? git status, git rebase etc. will list them as untracked files, which is annoying. So either there's a simple way to remove the files or they should go to .gitignore. > I'm willing to > fix whatever doesn't fit. > Thomas Thanks, Corinna