From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 0DAF9385C420 for ; Tue, 30 Nov 2021 15:14:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0DAF9385C420 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1638285262; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=jtCHOWnZLJUrZjgWiGxb+caBLrXPX0eMk5AT1qh+aLE=; b=htLv8g/U3gyylQFaWmc7Y9hYGMamJ0HyFSo0mMdiXUU1yi8mntRKvWGIMFtTSK0/RAaaNq kBZmjTkItcg0DTNHK2A73yv2klL+BAX3xQgsqf56zX/Gkp/xeVH3eiAWHbpDZvWxZq+0eN j5I44Bpw5TAbRxAvQOHVHJZdfieFUDc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-475-JN25N6OMOsCtR_TYVSzr1g-1; Tue, 30 Nov 2021 10:14:19 -0500 X-MC-Unique: JN25N6OMOsCtR_TYVSzr1g-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 452DD69737; Tue, 30 Nov 2021 15:14:18 +0000 (UTC) Received: from calimero.vinschen.de (ovpn-112-13.ams2.redhat.com [10.36.112.13]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 15F8D67845; Tue, 30 Nov 2021 15:14:18 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id 9C8E8A80A5B; Tue, 30 Nov 2021 16:14:16 +0100 (CET) Date: Tue, 30 Nov 2021 16:14:16 +0100 From: Corinna Vinschen To: Jonathan Wakely Cc: Mike Frysinger , newlib@sourceware.org, Richard Earnshaw Subject: Re: [PATCH 2/2] ctype: use less short names in public header Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: Jonathan Wakely , Mike Frysinger , newlib@sourceware.org, Richard Earnshaw References: <20211109012447.30698-1-vapier@gentoo.org> <20211109012459.30826-1-vapier@gentoo.org> <43a8b21c-ac4e-fd33-d7ad-ae7738329d16@foss.arm.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=vinschen@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_SHORT, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Nov 2021 15:14:24 -0000 On Nov 30 12:01, Jonathan Wakely wrote: > On 23/11/21 23:15 -0500, Mike Frysinger wrote: > > On 23 Nov 2021 15:09, Richard Earnshaw wrote: > > > This is wrong and breaks all old versions of C++. > > > > this is a bit vague. it would help if you provided details as to what broke. > > i doubt this broke all old versions of C++ everywhere. > > > > i'm guessing you're referring to the GNU C++ (libstdc++) library specifically > > and its hardcoding of newlib's internal ctype define names. > > https://gcc.gnu.org/git/?p=gcc.git;a=blob;f=libstdc%2B%2B-v3/config/os/newlib/ctype_base.h;hb=releases/gcc-11.2.0 > > Yes, you were CC'd on the GCC bug slightly before Richard sent his > email to this list: > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103305#c16 > > > if you're talking about something else, please state so clearly. > > > > > The GNU sim code should not be using reserved names (those starting _) > > > in normal source code. Such names are reserved to the implementation. > > > > that's not really a good reason to go pooping all over the namespace. > > > > we can maintain backwards compat here for C++ code fairly easily: > > Yes, or only do that for GCC < 12, as I suggested in > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103305#c19 > > #if defined(__GNUC__) && defined(__cplusplus) > # if __GNUC__ < 12 > > The libstdc++ code on trunk uses the new _ISupper names. > > I have no opinion on how long you should keep such backwards > compatibility around. Whatever time limit you set, at some point it > will make a new newlib release unusable with past G++ versions. Is there a good reason to revert these patches in newlib? I see the problem but I'm unclear on how problematic the change is in real life. Thanks, Corinna