From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 52A5D385801F for ; Tue, 30 Nov 2021 12:18:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 52A5D385801F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1638274713; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7UTnHoHzm/sY23KJ5pcE3Uf4I8YtHBI1lc11FtPxMA4=; b=MQIg++Kder5KqoUJAc4i35xsGoRToOXUZ4+kq38Eg+7ye6m4K0g3GdoPuH6AMTJ6asbihK QUgvFaig3LK0t213PtjnLrzYuH0LVQx4O58akzz3zV2DN5B03wbumS64IbzzZhbt15N8Nt pc2vDABMTbAyrnrCMcVmk+i1eEih/yI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-204-o1kz2YxQPQSmMB4g8z5eiw-1; Tue, 30 Nov 2021 07:18:29 -0500 X-MC-Unique: o1kz2YxQPQSmMB4g8z5eiw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 030D01853028; Tue, 30 Nov 2021 12:18:29 +0000 (UTC) Received: from localhost (unknown [10.33.36.16]) by smtp.corp.redhat.com (Postfix) with ESMTP id A9C1676613; Tue, 30 Nov 2021 12:18:28 +0000 (UTC) Date: Tue, 30 Nov 2021 12:18:27 +0000 From: Jonathan Wakely To: Mike Frysinger Cc: newlib@sourceware.org Subject: Re: [PATCH 2/2] ctype: use less short names in public header Message-ID: References: <20211109012447.30698-1-vapier@gentoo.org> <20211109012459.30826-1-vapier@gentoo.org> MIME-Version: 1.0 In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jwakely@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline X-Spam-Status: No, score=-8.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Nov 2021 12:18:34 -0000 On 09/11/21 19:18 -0500, Mike Frysinger wrote: >On 09 Nov 2021 12:38, Corinna Vinschen wrote: >> On Nov 8 20:24, Mike Frysinger wrote: >> > We're seeing a build failure in GNU sim code which is using _P locally >> > but the ctype.h define clashes with it. Rename these to use the same >> > symbols that glibc does. They're a bit more verbose, but seems likely >> > that we'll have fewer conflicts if glibc isn't seeing them. >> ^^^^^ >> Mixing newlib and glibc? That's just a typo, I guess? > >i meant glibc here. these are the same symbol names that glibc is using, >and it's not seeing conflicts in the wider ecosystem. so if they aren't >seeing issues, it's likely newlib won't either if it uses the same names. There's a reason you don't see conflicts with those names: They are reserved names, just like _P. Any user code that conflicts with those names has a bug and needs fixing.