From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id E5A29385841A for ; Fri, 3 Dec 2021 09:56:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E5A29385841A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1638525368; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=juz3QW2oz4eIu3d305zsa9Fr+MX8nMdJ/8JkJr/deYI=; b=PFC8OpihBX0TygDts8/wkUYfRuV6f/dFuEiMSOp7PvWmU/PXgjJxgelhK5Ayae5mz3KkxJ FtvU3533GhUxaEqLbXlbIVnpq8wP7hnXutwJFRBNPE68dGwX3fbzC04+pc3F/QL1xUKS36 e/ugLnBVzKazcAGeIGqTh1s3ruXU+gw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-105-nufPtH2GOJi7-24Dp9jeEg-1; Fri, 03 Dec 2021 04:56:07 -0500 X-MC-Unique: nufPtH2GOJi7-24Dp9jeEg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 80E1D81EE60 for ; Fri, 3 Dec 2021 09:56:06 +0000 (UTC) Received: from calimero.vinschen.de (ovpn-112-13.ams2.redhat.com [10.36.112.13]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 517595C1D5 for ; Fri, 3 Dec 2021 09:56:06 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id B0F95A80D61; Fri, 3 Dec 2021 10:56:04 +0100 (CET) Date: Fri, 3 Dec 2021 10:56:04 +0100 From: Corinna Vinschen To: newlib@sourceware.org Subject: Re: [PATCH 2/2] ctype: use less short names in public header Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org References: <20211109012447.30698-1-vapier@gentoo.org> <20211109012459.30826-1-vapier@gentoo.org> <43a8b21c-ac4e-fd33-d7ad-ae7738329d16@foss.arm.com> <29a9adf9-8251-d32b-6340-ea1d57ff4d9d@foss.arm.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=vinschen@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Dec 2021 09:56:10 -0000 On Dec 2 11:27, Corinna Vinschen wrote: > On Nov 30 17:52, Richard Earnshaw wrote: > > On 30/11/2021 17:15, Jonathan Wakely wrote: > > > On Tue, 30 Nov 2021 at 17:12, Jonathan Wakely wrote: > > > > > > > > On Tue, 30 Nov 2021 at 15:14, Corinna Vinschen wrote: > > > > > Is there a good reason to revert these patches in newlib? I see the > > > > > problem but I'm unclear on how problematic the change is in real life. > > > > > > > > You cannot use newlib from Git to build any released version of GCC. > > > > > > > > Is building newlib from Git only supported when using GCC trunk, or is > > > > > > Oops, I mean building *against* newlib from Git, not building newlib > > > itself. You can still build newlib itself, because it doesn't use C++. > > > But you can't build a GCC 11.2.0 compiler that uses the latest newlib > > > from Git as its libc. > > > > > > > it supposed to build with e.g. GCC 11.2.0 from July this year? If yes, > > > > then newlib needs changes (whether reverting the change entirely, or > > > > just making another change to restore the old names in addition to the > > > > new ones). > > > > > > > My concern is that the proposed workaround may break other (probably buggy) > > apps that have been relying on the old BSD internal API for 30 odd years. > > The proposed workaround only solves the issue for G++. > > I'm inclined to revert 3ba1bd0d9db, given it solves a problem which > isn't actually a problem in newlib, but in an application not following > the standards in terms of reserved symbols. > > I'm discussing this with Jeff, stay tuned. Reverted. Corinna