From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vapier@gentoo.org>
Received: from smtp.gentoo.org (dev.gentoo.org
 [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4])
 by sourceware.org (Postfix) with ESMTP id C01AA3858D3C
 for <newlib@sourceware.org>; Wed,  8 Dec 2021 17:47:05 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C01AA3858D3C
Authentication-Results: sourceware.org;
 dmarc=pass (p=none dis=none) header.from=gentoo.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org
Received: by smtp.gentoo.org (Postfix, from userid 559)
 id 8F31F3433C5; Wed,  8 Dec 2021 17:47:03 +0000 (UTC)
Date: Wed, 8 Dec 2021 12:47:09 -0500
From: Mike Frysinger <vapier@gentoo.org>
To: Jon Turney <jon.turney@dronecode.org.uk>
Cc: newlib@sourceware.org
Subject: Re: [PATCH] Cygwin: Conditionally build documentation
Message-ID: <YbDvnQLgjJyKFUEI@vapier>
Mail-Followup-To: Jon Turney <jon.turney@dronecode.org.uk>,
 newlib@sourceware.org
References: <20211208150340.1344-1-jon.turney@dronecode.org.uk>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature"; boundary="agFC0mOD88HeWWfY"
Content-Disposition: inline
In-Reply-To: <20211208150340.1344-1-jon.turney@dronecode.org.uk>
X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 KAM_SHORT, SPF_HELO_PASS, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: newlib@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Newlib mailing list <newlib.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/newlib>,
 <mailto:newlib-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/newlib/>
List-Post: <mailto:newlib@sourceware.org>
List-Help: <mailto:newlib-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/newlib>,
 <mailto:newlib-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Wed, 08 Dec 2021 17:47:07 -0000


--agFC0mOD88HeWWfY
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline

On 08 Dec 2021 15:03, Jon Turney wrote:
> +AC_ARG_ENABLE(doc,
> +	      [AS_HELP_STRING([--enable-doc], [Build documentation])],
> +	      enable_doc=$enableval,
> +	      enable_doc=yes)

the 3rd arg is redundant.  you can just write ,, to use the default iirc.

> +AC_CHECK_PROGS([DOCBOOK2XTEXI], [docbook2x-texi db2x_docbook2texi])
> +AC_CHECK_PROGS([XMLTO], [xmlto])
> +
> +if test "x$enable_doc" != "xno"; then
> +   if test -z "$DOCBOOK2XTEXI" || test -z "$XMLTO"; then
> +       AC_MSG_ERROR([Required documentation tools not found])
> +   fi
> +fi

i think AM_MISSING_PROG would be more appropriate.  then you don't need
the `test` logic.
https://www.gnu.org/software/automake/manual/html_node/Public-Macros.html#index-AM_005fMISSING_005fPROG
-mike

--agFC0mOD88HeWWfY
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmGw750ACgkQQWM7n+g3
9YG5fg//Z+DGRX3h2+ASZYH2AumrEbQCctHr7NQor8rZ+qbk0gvGePF7NQD1MlIg
ih5fH81JAFH9ZQYPSzvfWpSDVtF8RDDkkAy5a74FtFQI4mM4slXF/ZHvHttmmPIw
d2HCCOyD9JVTEoRpqF8eg9jHBjpdJ64+l+oTya3dA4czVxyGSQ2sHxYaIG3vF3f9
WRmJRxF67OMOI9dM+fgflNiiChxmyz5Rb89KvrkiwDo2jyybbF2Qj7ciIQi357Fa
jUzsBsOz7kdNrze9rWwJJ+SindTgPG816EIGDk2WARfSQgSetHRIFV7VpdHOPPr1
3ZfFZqpwOGdoZBOSnUUDxj1iV1Vg1rcojWRTF4YB1vw1JIpgB9kK1Y1AHJO0JCNh
Igi9vcmiHqzEK2yiw8ejFFk7yAtSs2ISF5cSsCpH1I+R5XjV37cnFlx4y2wbZp+O
3tjdTdniW/BRGaBP1pH25dtuNEqmAjdQFEDm5pp8XcjXbRdSYvPD7RXYhM021cSC
5+UajlTFWkAEPFt53vtn/oPskXa6FqQNZ5CuJzujgxF7/f1yNiO36siyLsquJbPw
gUKM/1Ju4xRXtm14OU5glUbiQV/92fOF1KVOfE2nHWyme/H8Xr4sbt3/6MMc+U9E
0jXCWpa9kFsupvDFdy+ZPnjpxodCW9HrKw3b6qhk2mfDgNhCZa4=
=2gFR
-----END PGP SIGNATURE-----

--agFC0mOD88HeWWfY--