From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id B16DC3857C7C for ; Fri, 10 Dec 2021 14:41:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B16DC3857C7C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1639147285; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=7ggoX/S/VOuMGEmnr+QzXLhNP8LG0uxRPGzj1o/lxo4=; b=PWAfk6idpd7okxIzwTW8+1c1rmxwQjpX358dxFXxEntP8TPUbC3rbh9ooiJUvGnVTH5wCr 3cB1Q4ekYW3lzixR6jBXPINBCpbpRVtoAhh8j+7IDHpmcTXIqUwKdqPH6aD4YqiW2YD0A9 5+A0vr1/MpjcXgBkcROQEUamQmH1oKE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-568-lVMfjnejPES8coQ32-1XeA-1; Fri, 10 Dec 2021 09:41:18 -0500 X-MC-Unique: lVMfjnejPES8coQ32-1XeA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D3ACA1B2C983 for ; Fri, 10 Dec 2021 14:41:17 +0000 (UTC) Received: from calimero.vinschen.de (ovpn-112-13.ams2.redhat.com [10.36.112.13]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A5A785DF37 for ; Fri, 10 Dec 2021 14:41:17 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id 26F63A80D58; Fri, 10 Dec 2021 15:41:16 +0100 (CET) Date: Fri, 10 Dec 2021 15:41:16 +0100 From: Corinna Vinschen To: newlib@sourceware.org Subject: Re: [PATCH] Add a script for regenerating all newlib autotools files Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org References: <20211209214721.39306-1-jon.turney@dronecode.org.uk> <5b6927aa-8244-04a6-8558-3cd8b6b7abec@dronecode.org.uk> MIME-Version: 1.0 In-Reply-To: <5b6927aa-8244-04a6-8558-3cd8b6b7abec@dronecode.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=vinschen@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-12.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Dec 2021 14:41:28 -0000 On Dec 10 14:14, Jon Turney wrote: > On 10/12/2021 08:58, Corinna Vinschen wrote: > > Hi Jon, > > > > On Dec 9 21:47, Jon Turney wrote: > > > Add a script for regenerating all newlib autotools files, applying the > > > instructions in the 'Regenerating Configuration Files' section of the > > > README everywhere. > > > > Great idea. > > > > > Running this script produces loads of errors about 'no AC_LANG_SOURCE > > > call detected in body' from libtool.m4. This is because that file is > > > old. > > > > > > The versions of autotools in use on newlib seem to have backslid since > > > the README was last updated (for newlib 2.1.0 in 2013), so bring those > > > into alignment. I don't know why. I'm a little skeptical that automake > > > 1.13 was used, since that doesn't permit '--cygnus', which we use. > > > --- > > > newlib/README | 4 ++-- > > > newlib/autogen.sh | 35 +++++++++++++++++++++++++++++++++++ > > > 2 files changed, 37 insertions(+), 2 deletions(-) > > > create mode 100755 newlib/autogen.sh > > > > > > diff --git a/newlib/README b/newlib/README > > > index 1c0541284..d47cccbcb 100644 > > > --- a/newlib/README > > > +++ b/newlib/README > > > [...] > > > +# automake > > > +find -name configure.ac | while read f > > > +do > > > + # Exclude directories containing a configure.ac and below, so that Makefile.in > > > + # files are generated from the nearest directory up the tree which contains a > > > + # configure.ac file. > > > + (cd $(dirname $f) ; find -type d -execdir test -e {}/configure.ac ';' -a -not -path '.' -prune -o -name Makefile.am -printf '%P\n' | while read m > > > + do > > > + automake-1.11 -ac ${m%.*} > > > > Not being an automake guru at all, but... isn't the --cygnus option missing? > > That's not actually required as every Makefile.am contains 'AUTOMAKE_OPTIONS > = cygnus'. > > I am working on a patch to remove '--cygnus' (since I thought that would be > a prerequisite of silent make until I checked which automake versions added > it), but not finished yet... Great, feeel free to push. Thanks, Corinna