From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 562833858D28 for ; Fri, 7 Jan 2022 09:32:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 562833858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1641547939; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=5Qo6RxYz+cxvQaRHrwVakGwbHEvxRAoVo8V35BxLVtY=; b=aTdS4GMJjwDbKHAofrHtoVVtZtF7/1So0NTs1Q1i/KDwROhOlS3KwRBSObClDmwQCg8HcK xZKOZNI67EDheC6EwU7ZcuKE1pgFxF7uMaBmCHNwvZNYwnelncY+87obOFz0AAYRym7qLa +qFxoZ/paAXbA+5sZltaO2qcTGdSEbI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-599-ptyQQsf4NI28sifC4ZR-eA-1; Fri, 07 Jan 2022 04:32:16 -0500 X-MC-Unique: ptyQQsf4NI28sifC4ZR-eA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4E58118B9EC8; Fri, 7 Jan 2022 09:32:15 +0000 (UTC) Received: from calimero.vinschen.de (ovpn-112-6.ams2.redhat.com [10.36.112.6]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DB7C61F312; Fri, 7 Jan 2022 09:32:14 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id A84C4A8093E; Fri, 7 Jan 2022 10:32:12 +0100 (CET) Date: Fri, 7 Jan 2022 10:32:12 +0100 From: Corinna Vinschen To: Keith Thompson Cc: newlib@sourceware.org Subject: Re: Error in posix_spawn(3) man page Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: Keith Thompson , newlib@sourceware.org References: MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=vinschen@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Jan 2022 09:32:23 -0000 Hi Keith, On Jan 5 13:39, Keith Thompson wrote: > On Wed, Jan 5, 2022 at 3:47 AM Corinna Vinschen wrote: > > > > Hi Keith, > > > > On Dec 28 19:24, Keith Thompson wrote: > > > The posix_spawn(3) man page has incorrect types for the argv and > > > envp parameters for the posix_spawn and posix_spawnp functions. > > > > > > They're shown as > > > char *const argv, char *const envp > > > when they should be > > > char *const argv[], char *const envp[] > > > > > > Suggested patch (though I'm not 100% sure how the square brackets > > > are handled when generating the man page): > > > > Please send a git compatible patch in `git format-patch' format. > > > > > > Thanks, > > Corinna > > As requested. Given the way I copy-and-pasted the patch into my email, > it might not have > treated tabs correctly. It's not TABs, it's an incorrect patch format: $ git am 0001-Fix-documented-argv-and-envp-params-for-posix_spawn.patch Applying: Fix documented argv and envp params for posix_spawn error: libc/posix/posix_spawn.c: does not exist in index Patch failed at 0001 Fix documented argv and envp params for posix_spawn hint: Use 'git am --show-current-patch=diff' to see the failed patch [...] Did you actually create the patch with `git format-patch'? Thanks, Corinna