From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id E6E3C3858D39 for ; Mon, 24 Jan 2022 16:39:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E6E3C3858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643042361; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=P/ESMxAlkY1j+S/QztUjQ2rwaEzDvMnqnefl8YVr9qY=; b=i2LvDKp3d5629z8HZkPkZKYOmy5VKftiidNkynlzXX0kFQitVM7idhJVIqp2zm7e0ofvrh YGodwr3qR0WE+GgjiW/i4dEsaF+Cl5MGbhTOUE5dz+cs2EuXMOPjpzo6e5WIUPtZAf5rxS ZtHIHHSn8YH1Plk5UV2+Pwynojd8i5c= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-376-CBY-x_srNm-PipZooH833Q-1; Mon, 24 Jan 2022 11:39:20 -0500 X-MC-Unique: CBY-x_srNm-PipZooH833Q-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 24B50193578F for ; Mon, 24 Jan 2022 16:39:17 +0000 (UTC) Received: from calimero.vinschen.de (ovpn-112-15.ams2.redhat.com [10.36.112.15]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E9FAE1092002 for ; Mon, 24 Jan 2022 16:39:16 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id 46815A8078D; Mon, 24 Jan 2022 17:39:15 +0100 (CET) Date: Mon, 24 Jan 2022 17:39:15 +0100 From: Corinna Vinschen To: newlib@sourceware.org Subject: Re: [PATCH] newlib: update nds32 configure checks Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org References: <20220123013933.911-1-vapier@gentoo.org> MIME-Version: 1.0 In-Reply-To: <20220123013933.911-1-vapier@gentoo.org> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=vinschen@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Jan 2022 16:39:26 -0000 On Jan 22 20:39, Mike Frysinger wrote: > This subdir doesn't link any code, so there's no need to require > AC_NO_EXECUTABLES, and no other dir uses this either. Punt it. > > The two tests in here are using compile tests to look for some > preprocessor defines, but we don't need to compile the code, > just preprocess it. So switch to AC_PREPROC_IFELSE. > --- > newlib/libm/machine/nds32/Makefile.in | 1 + > newlib/libm/machine/nds32/configure | 266 +++++++++++++++++-------- > newlib/libm/machine/nds32/configure.ac | 5 +- > 3 files changed, 186 insertions(+), 86 deletions(-) > mode change 100644 => 100755 newlib/libm/machine/nds32/configure LGTM Thanks, Corinna