From: Corinna Vinschen <vinschen@redhat.com>
To: newlib@sourceware.org
Subject: Re: [PATCH] newlib: update preprocessor configure checks
Date: Mon, 24 Jan 2022 17:39:25 +0100 [thread overview]
Message-ID: <Ye7WPcrpv4QW6P6n@calimero.vinschen.de> (raw)
In-Reply-To: <20220123052547.10003-1-vapier@gentoo.org>
On Jan 23 00:25, Mike Frysinger wrote:
> The nds32 & spu dirs are using compile tests to look for some
> preprocessor defines, but we don't need to compile the code,
> just preprocess it. So switch to AC_PREPROC_IFELSE.
>
> The sh dir is using a preprocessor test via grep, but let's
> switch it to AC_PREPROC_IFELSE too to be consistent.
>
> This should allow us to drop the uncommon AC_NO_EXECUTABLES call.
> ---
> newlib/libc/machine/nds32/Makefile.in | 1 +
> newlib/libc/machine/nds32/configure | 264 +++--
> newlib/libc/machine/nds32/configure.ac | 9 +-
> newlib/libc/machine/sh/Makefile.in | 2 -
> newlib/libc/machine/sh/configure | 232 +----
> newlib/libc/machine/sh/configure.ac | 10 +-
> newlib/libc/machine/spu/Makefile.in | 6 +
> newlib/libc/machine/spu/aclocal.m4 | 64 ++
> newlib/libc/machine/spu/configure | 1318 +++++++++++++++++++++---
> newlib/libc/machine/spu/configure.ac | 15 +-
> newlib/libm/machine/nds32/Makefile.in | 1 +
> newlib/libm/machine/nds32/configure | 270 +++--
> newlib/libm/machine/nds32/configure.ac | 17 +-
> 13 files changed, 1656 insertions(+), 553 deletions(-)
> mode change 100644 => 100755 newlib/libm/machine/nds32/configure
LGTM
Thanks,
Corinna
next prev parent reply other threads:[~2022-01-24 16:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-23 1:39 [PATCH] newlib: update nds32 " Mike Frysinger
2022-01-23 5:25 ` [PATCH] newlib: update preprocessor " Mike Frysinger
2022-01-24 16:39 ` Corinna Vinschen [this message]
2022-01-24 16:39 ` [PATCH] newlib: update nds32 " Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ye7WPcrpv4QW6P6n@calimero.vinschen.de \
--to=vinschen@redhat.com \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).