From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 932B33858D3C for ; Mon, 24 Jan 2022 16:45:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 932B33858D3C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643042723; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=AYKpBiRcEQ0VFadE5GFzsHWtTBsOpUcizQtQbCpDQTU=; b=InMc+NdzCiWOkhzyRmWoKTcOhb18p2RPdxsOHme5seQFmktyEMEibrlfrmJX6HapPkpkrK FVJT6fTGuwT5/6mrYWPPz1JIu2slSvA8Xqm7Sok8/WdTHTOu8o6GlczMbCqFtEnleLnLJ0 G2WMY272ZYkl49p53UgUQk7phB2eQJk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-280-At6jNcnqPTGvI8vLru8X-A-1; Mon, 24 Jan 2022 11:45:20 -0500 X-MC-Unique: At6jNcnqPTGvI8vLru8X-A-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 743FC85EE61 for ; Mon, 24 Jan 2022 16:45:19 +0000 (UTC) Received: from calimero.vinschen.de (ovpn-112-15.ams2.redhat.com [10.36.112.15]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2AF027DE4F for ; Mon, 24 Jan 2022 16:45:19 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id BAAEFA8078D; Mon, 24 Jan 2022 17:45:17 +0100 (CET) Date: Mon, 24 Jan 2022 17:45:17 +0100 From: Corinna Vinschen To: newlib@sourceware.org Subject: Re: [PATCH] newlib: merge iconvdata into top-level Makefile Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org References: <20220122060458.7539-1-vapier@gentoo.org> MIME-Version: 1.0 In-Reply-To: <20220122060458.7539-1-vapier@gentoo.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=vinschen@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Jan 2022 16:45:24 -0000 On Jan 22 01:04, Mike Frysinger wrote: > Avoid a recursive make with this tiny subdir to speed things up a bit. > --- > NB: I can't easily test this because it's only built for i686-pc-linux, > and I only have GNU C library toolchains using that tuple. My half > attempts at building it *look* like it uses the right flags. > > newlib/Makefile.am | 7 +- > newlib/Makefile.in | 186 +- > newlib/configure | 22 +- > newlib/configure.ac | 6 +- > newlib/iconvdata/Makefile.am | 23 - > newlib/iconvdata/Makefile.in | 643 -- > newlib/iconvdata/aclocal.m4 | 1178 --- > newlib/iconvdata/configure | 14169 -------------------------------- > newlib/iconvdata/configure.ac | 22 - > newlib/iconvdata/local.mk | 20 + > 10 files changed, 201 insertions(+), 16075 deletions(-) > delete mode 100644 newlib/iconvdata/Makefile.am > delete mode 100644 newlib/iconvdata/Makefile.in > delete mode 100644 newlib/iconvdata/aclocal.m4 > delete mode 100755 newlib/iconvdata/configure > delete mode 100644 newlib/iconvdata/configure.ac > create mode 100644 newlib/iconvdata/local.mk Looks good, except, there's this local.mk again. I don't think this name is overly helpful. All Makefiles, even those just included by the master Makefile should be called Makefile.somethingorother, IMHO. These are much easier to find for people new to the stuff. Same goes for the already existing newlib/doc/local.mk which I missed when reviewing the patches... Thanks, Corinna