From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 661AC3857C6E for ; Wed, 19 Jan 2022 14:51:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 661AC3857C6E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1642603896; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=Sw2BvyVkqK5ej7rvv4ynXU5VMUhKCQnq5xJvbQPK5L8=; b=IrLREWe2iUs15lzsrXaPceqcvWB0ScWevRRNBvpfEAzJY7dyTt91mpYuFdMn1Hy7m1giz5 V5kryVFFZFkdH6gFOQK9IjURr1sZQSJony3kc0MEX9eE27Os35SaifWjcD9Znm2WE1+P7c XBySTR+2040ibULHchIGnodj02mJ1uI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-594-gBIzgFltOpWjUmt8XIrsWA-1; Wed, 19 Jan 2022 09:51:34 -0500 X-MC-Unique: gBIzgFltOpWjUmt8XIrsWA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id F201E46861 for ; Wed, 19 Jan 2022 14:51:33 +0000 (UTC) Received: from calimero.vinschen.de (ovpn-112-9.ams2.redhat.com [10.36.112.9]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C1CAD7E64B for ; Wed, 19 Jan 2022 14:51:33 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id 44943A80D67; Wed, 19 Jan 2022 15:51:32 +0100 (CET) Date: Wed, 19 Jan 2022 15:51:32 +0100 From: Corinna Vinschen To: newlib@sourceware.org Subject: Re: [PATCH 0/8] newlib: convert newlib.h to autoheader Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org References: <20220118044741.21027-1-vapier@gentoo.org> MIME-Version: 1.0 In-Reply-To: <20220118044741.21027-1-vapier@gentoo.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=vinschen@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Jan 2022 14:51:41 -0000 On Jan 17 23:47, Mike Frysinger wrote: > This is a series of cleanups to make newlib.hin be managed automatically > by autoheader instead of being hand maintained. This will also make the > standard autoreconf command not fall over due to the current poor state > of the header files, as well as not make it corrupt/clobber the version > header file. > > I've split these up to (hopefully) make it easier to review, and be easy > to merge most of them independently. If there is some reason we don't > want to actually leverage autoheader, or maybe we want to rework how the > final step is done, we can still land the rest of the stack while that > discussion is ongoing. > > Mike Frysinger (8): > newlib: internalize HAVE_INITFINI_ARRAY > newlib: merge acconfig.h changes into newlib.hin > newlib: clean up autoheader templates > newlib: sort newlib.h output > newlib: move version defines out of the config headers > newlib: add missing _NANO_MALLOC to newlib.hin > newlib: iconv: autogenerate iconv define list > newlib: switch newlib.h to autoheader > > newlib/Makefile.in | 34 +- > newlib/_newlib_version.hin | 16 +- > newlib/acconfig.h | 191 -------- > newlib/aclocal.m4 | 1 + > newlib/configure | 695 ++++++++++++++++++++++++----- > newlib/configure.ac | 105 +++-- > newlib/configure.host | 2 +- > newlib/iconv.m4 | 305 +++++++++++++ > newlib/libc/iconv/ces/mkdeps.pl | 39 ++ > newlib/libc/misc/fini.c | 6 +- > newlib/libc/misc/init.c | 6 +- > newlib/libc/stdlib/__call_atexit.c | 2 +- > newlib/libc/sys/arm/crt0.S | 2 +- > newlib/newlib.hin | 503 +++++++++++++++------ > 14 files changed, 1398 insertions(+), 509 deletions(-) > delete mode 100644 newlib/acconfig.h > create mode 100644 newlib/iconv.m4 > > -- > 2.33.0 The patchset looks good to me. Please push. Thanks, Corinna