From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 2CC3E385AC24 for ; Fri, 21 Jan 2022 13:26:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2CC3E385AC24 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1642771565; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=iSohXeUz123in1uNHHV44SuUPhEhWZ1SRckD2ciYEVk=; b=MyBbAFDx7TJiShBKGUCvldkW2ysdzewhIyV+NBRM/+uo7oQiIh0mGc4fc+679GCTM1MM3u 0/gl1Y67CgvQ36IEzf5Jo5ZYeyl38esW4w71BuoeTE+COhOWBwOwu5BH8Zht5G/Z/eJrbM U6mv2fx2gSEteiEw2HcMBwJd4Mgaxoo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-126-LsvKNnp4N0mOMfzW5jsn_Q-1; Fri, 21 Jan 2022 08:26:04 -0500 X-MC-Unique: LsvKNnp4N0mOMfzW5jsn_Q-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CC3568189CF for ; Fri, 21 Jan 2022 13:26:03 +0000 (UTC) Received: from calimero.vinschen.de (ovpn-112-9.ams2.redhat.com [10.36.112.9]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9B9817D72A for ; Fri, 21 Jan 2022 13:26:03 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id 155F4A8078D; Fri, 21 Jan 2022 14:26:02 +0100 (CET) Date: Fri, 21 Jan 2022 14:26:02 +0100 From: Corinna Vinschen To: newlib@sourceware.org Subject: Re: [PATCH 1/2] newlib: move to ../config/multi.m4 for multilib logic Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org References: <20220121035823.11754-1-vapier@gentoo.org> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=vinschen@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Jan 2022 13:26:09 -0000 On Jan 21 07:17, Mike Frysinger wrote: > On 21 Jan 2022 12:23, Corinna Vinschen wrote: > > On Jan 20 22:58, Mike Frysinger wrote: > > > The current newlib multilib logic is almost exactly the same as the > > > config/multi.m4, and the differences should be minor, so switch over > > > to that to delete custom logic on ourside. > > > > What differences are that? > > the differences don't affect the actual compilation. > > newlib/configure.ac uses AC_CONFIG_FILES to hack up Makefile. multi.m4 > uses AC_OUTPUT_COMMANDS instead. > > newlib/configure.ac passes LDFLAGS to init-cmds while multi.m4 does not > (it does pass additional non-C toolchain vars that newlib doesn't use). > afaict omitting LDFLAGS shouldn't make a diff since newlib has been > clobbering that with an invalid setting ($ldflags). > > there's also a few internal variable names that changed, but since newlib > doesn't check them, it shouldn't matter. > > > Did you check them? > > yes, i've build every commit against bfin-elf multilib. if you want me > to check something specifically, please highlight it. > -mike No it's fine. I just checked again Cygwin which still works, apparently. Please push. Thanks, Corinna