From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id D18343857814 for ; Fri, 21 Jan 2022 11:25:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D18343857814 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1642764349; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=bxvGmCUm/DpJsjdMVWorrC94WzfodzVmW+xbnmd4080=; b=hm3M3TS7xcL4Z6NKw/n9heRU1Btym/XvKdksnEnYq0cZ6xxK8JrC2zychpRlC9JgX5CAaQ ZUVlNlQnWpbvsxNPU7YLszVF1qRHdGMYmw+TZeoj14RCW4eXLY41FotJ2H1ZdLORC0dFK7 qXkOeMeLtd2F5jzIaKrJIeELzF8Ht/4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-120-fpBryIrMO6mPnkBpTF7INw-1; Fri, 21 Jan 2022 06:25:48 -0500 X-MC-Unique: fpBryIrMO6mPnkBpTF7INw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8330D814243 for ; Fri, 21 Jan 2022 11:25:47 +0000 (UTC) Received: from calimero.vinschen.de (ovpn-112-9.ams2.redhat.com [10.36.112.9]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 52C3D753CD for ; Fri, 21 Jan 2022 11:25:47 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id C995CA807CF; Fri, 21 Jan 2022 12:25:45 +0100 (CET) Date: Fri, 21 Jan 2022 12:25:45 +0100 From: Corinna Vinschen To: newlib@sourceware.org Subject: Re: [PATCH] newlib: stop clobbering LDFLAGS with non-standard $ldflags Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org References: <20220121045152.21131-1-vapier@gentoo.org> MIME-Version: 1.0 In-Reply-To: <20220121045152.21131-1-vapier@gentoo.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=vinschen@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Jan 2022 11:25:50 -0000 On Jan 20 23:51, Mike Frysinger wrote: > It's unclear why this was added originally, but assuming it was needed > 20 years ago, it shouldn't be explicitly required nowadays. Current > versions of autotools already take care of exporting LDFLAGS to the > Makefile as needed (things are actually getting linked). That's why > the configure diffs show LDFLAGS still here, but shifted to a diff > place in the output list. A few dirs stop exporting LDFLAGS, but > that's because they don't do any linking, only compiling, so it's > correct. > > As for the use of $ldflags instead of the standard $LDFLAGS, I can't > really explain that at all. Just use the right name so users don't > have to dig into why their setting isn't respected, and then use a > non-standard name instead. Adjust the testsuite to match. LGTM, thanks, Corinna